You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/19 11:16:44 UTC

Review Request 54859: Shortened socket paths used in test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54859/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-6811
    https://issues.apache.org/jira/browse/MESOS-6811


Repository: mesos


Description
-------

The maximal path length for a Unix domain socket is 104 characters on
e.g., OS X. Drop a redundant UUID from the socket path to make sure that
the path fits into the platform restrictions.


Diffs
-----

  src/tests/containerizer/io_switchboard_tests.cpp 930f98f45acb03d6773e85a25481a9dcc4bec78d 

Diff: https://reviews.apache.org/r/54859/diff/


Testing
-------


Thanks,

Benjamin Bannier

Re: Review Request 54859: Shortened socket paths used in test.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54859/#review159641
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Dec. 19, 2016, 3:16 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54859/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 3:16 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-6811
>     https://issues.apache.org/jira/browse/MESOS-6811
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The maximal path length for a Unix domain socket is 104 characters on
> e.g., OS X. Drop a redundant UUID from the socket path to make sure that
> the path fits into the platform restrictions.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 930f98f45acb03d6773e85a25481a9dcc4bec78d 
> 
> Diff: https://reviews.apache.org/r/54859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>