You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2023/01/05 03:15:46 UTC

[GitHub] [incubator-celeborn] FMX opened a new pull request, #1142: [CELEBORN-193][FOLLOWUP] Reduce unnecessary binary files.

FMX opened a new pull request, #1142:
URL: https://github.com/apache/incubator-celeborn/pull/1142

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1142: [CELEBORN-193][FOLLOWUP] Reduce unnecessary binary files.

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #1142:
URL: https://github.com/apache/incubator-celeborn/pull/1142#discussion_r1062096634


##########
build/make-distribution.sh:
##########
@@ -220,5 +220,5 @@ TARDIR_NAME="apache-celeborn-$VERSION-$NAME"
 TARDIR="$PROJECT_DIR/$TARDIR_NAME"
 rm -rf "$TARDIR"
 cp -R "$DIST_DIR" "$TARDIR"
-tar czf "apache-celeborn-$VERSION-$NAME.tgz" -C "$PROJECT_DIR" "$TARDIR_NAME"
+tar -cz --no-xattrs --disable-copyfile --exclude='.DS_Store' -f "apache-celeborn-$VERSION-$NAME.tgz" -C "$PROJECT_DIR" "$TARDIR_NAME"

Review Comment:
   what's "--disable-copyfile" for? I can not find it in `man tar`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture merged pull request #1142: [CELEBORN-193][FOLLOWUP] Reduce unnecessary binary files.

Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1142:
URL: https://github.com/apache/incubator-celeborn/pull/1142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1142: [CELEBORN-193][FOLLOWUP] Reduce unnecessary binary files.

Posted by GitBox <gi...@apache.org>.
waitinfuture commented on PR #1142:
URL: https://github.com/apache/incubator-celeborn/pull/1142#issuecomment-1371770210

   I've tested on CentOS and things goes well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1142: [CELEBORN-193][FOLLOWUP] Reduce unnecessary binary files.

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1142:
URL: https://github.com/apache/incubator-celeborn/pull/1142#issuecomment-1371741757

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1142](https://codecov.io/gh/apache/incubator-celeborn/pull/1142?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abf7a91) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/01b7ea97c98e7732b7af934ea2d24e59e6d3c3da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01b7ea9) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1142      +/-   ##
   ============================================
   - Coverage     26.95%   26.93%   -0.02%     
   + Complexity      748      746       -2     
   ============================================
     Files           196      196              
     Lines         16835    16856      +21     
     Branches       1821     1822       +1     
   ============================================
   + Hits           4537     4538       +1     
   - Misses        12004    12023      +19     
   - Partials        294      295       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `76.58% <0.00%> (-1.35%)` | :arrow_down: |
   | [.../service/deploy/worker/storage/DeviceMonitor.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvRGV2aWNlTW9uaXRvci5zY2FsYQ==) | `5.77% <0.00%> (-0.70%)` | :arrow_down: |
   | [.../celeborn/service/deploy/worker/WorkerSource.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlclNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1142: [CELEBORN-193][FOLLOWUP] Reduce unnecessary binary files.

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #1142:
URL: https://github.com/apache/incubator-celeborn/pull/1142#discussion_r1062097136


##########
build/make-distribution.sh:
##########
@@ -220,5 +220,5 @@ TARDIR_NAME="apache-celeborn-$VERSION-$NAME"
 TARDIR="$PROJECT_DIR/$TARDIR_NAME"
 rm -rf "$TARDIR"
 cp -R "$DIST_DIR" "$TARDIR"
-tar czf "apache-celeborn-$VERSION-$NAME.tgz" -C "$PROJECT_DIR" "$TARDIR_NAME"
+tar -cz --no-xattrs --disable-copyfile --exclude='.DS_Store' -f "apache-celeborn-$VERSION-$NAME.tgz" -C "$PROJECT_DIR" "$TARDIR_NAME"

Review Comment:
   do we need `--exclude='.DS_Store'`? it only exists if you opened the folder using `Finder`, I think we don't need that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org