[GitHub] [lucene-solr] kamaci opened a new pull request #838: SOLR-13705 Double-checked locking bug is fixed.

[GitBox <gi...@apache.org>]

kamaci opened a new pull request #838: SOLR-13705 Double-checked locking bug is fixed.
URL: https://github.com/apache/lucene-solr/pull/838
 
 
   # Description
   
   Using double-checked locking for the lazy initialization of any other type of primitive or mutable object risks a second thread using an uninitialized or partially initialized member while the first thread is still creating it, and crashing the program.
   
   # Solution
   
   Double-checked locking bug is fixed to prevent it.
   
   # Tests
   
   No need to write extra tests. Existing tests should not fail after this implementation.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org