You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/01 15:25:12 UTC
[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3421: [ARTEMIS-3080]: Provide JakartaEE 9 artefacts.
gemmellr commented on a change in pull request #3421:
URL: https://github.com/apache/activemq-artemis/pull/3421#discussion_r567891785
##########
File path: artemis-jakarta-client/pom.xml
##########
@@ -0,0 +1,64 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-jakarta-client</artifactId>
+ <packaging>jar</packaging>
+ <name>ActiveMQ Artemis JakartaEE Messaging Client</name>
Review comment:
Isn't the name just Jakarta Messaging? (i.e not JakartaEE Messaging)
##########
File path: artemis-jakarta-client/pom.xml
##########
@@ -0,0 +1,64 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-jakarta-client</artifactId>
+ <packaging>jar</packaging>
+ <name>ActiveMQ Artemis JakartaEE Messaging Client</name>
+
+ <properties>
+ <activemq.basedir>${project.basedir}/..</activemq.basedir>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
Review comment:
Feels a bit odd that this module doesn't seem to actually end up with a dependency on the new API, shouldnt it? Actually, what about all the other client deps too for that matter, aren't they are omitted also...how would someone use this module currently?
##########
File path: pom.xml
##########
@@ -1816,7 +1874,26 @@
</configuration>
</plugin>
-
+ <plugin>
+ <groupId>org.wildfly.extras.batavia</groupId>
+ <artifactId>transformer-tools-mvn</artifactId>
+ <executions>
+ <execution>
+ <id>transform</id>
+ <phase>process-classes</phase>
+ <goals>
+ <goal>transform-classes</goal>
+ </goals>
+ </execution>
+ </executions>
+ <dependencies>
+ <dependency>
+ <groupId>org.wildfly.extras.batavia</groupId>
+ <artifactId>transformer-impl-eclipse</artifactId>
+ <version>${version.batavia}</version>
+ </dependency>
+ </dependencies>
+ </plugin>
Review comment:
Defining the execution here will mean the plugin runs (though doesn't necessarily do anything) for every module in the build. Is that needed, seems a bit ugly?
I dont recall it being that way last week when skimming the changes. If this came about to try and have the transformer-impl-eclipse dep version be consistent, just using the property in the previous places the version was specified would seem preferable if there isnt a specific reason this approach was needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org