You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/03/10 00:51:19 UTC

[GitHub] spark pull request #17177: [SPARK-19834][SQL] csv escape of quote escape

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17177#discussion_r105306195
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala ---
    @@ -88,6 +88,7 @@ private[csv] class CSVOptions(
     
       val quote = getChar("quote", '\"')
       val escape = getChar("escape", '\\')
    +  val escapeEscape = getChar("escapeEscape", quote)
    --- End diff --
    
    Also, I would make this as an option for this CSV datasource. I think we should document this in `DataFrameReader`, `DataStreamReader`, `readwriter.py` and `streaming.py`. 
    
    Lastly, how about making this from `escapeEscape ` to `escapeQuoteEscaping` in order to take after the original name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org