You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "mivanac (GitHub)" <gi...@apache.org> on 2020/03/27 11:32:07 UTC

[GitHub] [geode] mivanac opened pull request #4858: GEODE-7917: change thrown exception type for SSL to IOException

WIP: do not review

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [*] Is your initial contribution a single, squashed commit?

- [*] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on pull request #4858: GEODE-7917: change thrown exception type for SSL to IOException

Posted by "mivanac (GitHub)" <gi...@apache.org>.

Thanks for comments.

[ Full content available at: https://github.com/apache/geode/pull/4858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mkevo commented on pull request #4858: GEODE-7917: change thrown exception type for SSL to IOException

Posted by "mkevo (GitHub)" <gi...@apache.org>.

Also remove this. Thanks.

[ Full content available at: https://github.com/apache/geode/pull/4858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mkevo commented on pull request #4858: GEODE-7917: change thrown exception type for SSL to IOException

Posted by "mkevo (GitHub)" <gi...@apache.org>.

The same.

[ Full content available at: https://github.com/apache/geode/pull/4858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org