You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Moriadry (GitHub)" <gi...@apache.org> on 2020/02/11 12:38:15 UTC
[GitHub] [dubbo] Moriadry opened pull request #5734: [Dubbo-5130]
complete lfu cache proposal
## What is the purpose of the change
fix https://github.com/apache/dubbo/issues/5130
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] Moriadry commented on issue #5734: [Dubbo-5130]
complete lfu cache proposal
Posted by "Moriadry (GitHub)" <gi...@apache.org>.
@cvictory hi, do you mean something like wechat? my id: arse554321
[ Full content available at: https://github.com/apache/dubbo/pull/5734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5734: [Dubbo-5130]
complete lfu cache proposal
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=h1) Report
> Merging [#5734](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/60e72bf5c91657dfae8106979cd00106e4764bab?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `72.56%`.
[](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5734 +/- ##
============================================
- Coverage 61.43% 61.36% -0.08%
- Complexity 497 498 +1
============================================
Files 932 931 -1
Lines 38098 38060 -38
Branches 5500 5500
============================================
- Hits 23405 23354 -51
- Misses 12149 12179 +30
+ Partials 2544 2527 -17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/dubbo/cache/support/lfu/LfuCache.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9sZnUvTGZ1Q2FjaGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...pache/dubbo/cache/support/lfu/LfuCacheFactory.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC9sZnUvTGZ1Q2FjaGVGYWN0b3J5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...n/java/org/apache/dubbo/common/utils/LFUCache.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTEZVQ2FjaGUuamF2YQ==) | `79.61% <79.61%> (ø)` | `0 <0> (?)` | |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../context/properties/AbstractDubboConfigBinder.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0Fic3RyYWN0RHViYm9Db25maWdCaW5kZXIuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `39.47% <0%> (-10.53%)` | `15% <0%> (-1%)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0%> (-6.9%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `57.62% <0%> (-6.78%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `78.35% <0%> (-2.99%)` | `0% <0%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/dubbo/pull/5734/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=footer). Last update [60e72bf...e8d07c6](https://codecov.io/gh/apache/dubbo/pull/5734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org