You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/11/05 01:22:05 UTC

[GitHub] [samza] abhishekshivanna commented on issue #1207: SAMZA-2364: Include the localized resource lib directory in the classpath of SamzaContainer

abhishekshivanna commented on issue #1207: SAMZA-2364: Include the localized resource lib directory in the classpath of SamzaContainer
URL: https://github.com/apache/samza/pull/1207#issuecomment-549621168
 
 
   Looks good to me. 
   nit: can rename `LOCALIZED_RESOURCE_LIB_DIR` to something along the lines of `ADDITIONAL_CLASSPATH_DIR` - to make this YARN agnostic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services