Re: [PR] [improve][doc] Note runtime support for maxMessageRetries and deadLetterTopic [pulsar-site]

["david-streamlio (via GitHub)" <gi...@apache.org>]

david-streamlio commented on PR #1214:
URL: https://github.com/apache/pulsar-site/pull/1214#issuecomment-5501337821

   Pushed `000346a`, which adds the pulsar-client requirement @lhotari asked for in
   apache/pulsar#26400.
   
   One thing that turned up while writing it: the requirement is not specific to `maxMessageRetries` /
   `deadLetterTopic`. The Python runtime passes `dead_letter_policy` to `Client.subscribe()` for **every**
   input topic — as `None` when nothing is configured — so `pulsar-client` 3.3.0 is the floor for all
   Python functions, not just ones using a dead letter topic. I diffed every keyword the runtime passes
   against the 3.2.0 signature and `dead_letter_policy` is the only one missing, so 3.3.0 is exactly the
   floor and nothing else in the runtime was already above it.
   
   That is why the main note went on **Package Python functions** rather than only into the CLI table.
   While there I also changed the documented install from `pulsar-client==2.10.0` to
   `pulsar-client>=3.3.0` — following the page as written would have produced a runtime that fails at
   `subscribe()`. Happy to split that into its own PR if you would rather keep this one to the CLI table.
   
   The `functions-cli.md` rows now also record that an empty `deadLetterTopic` leaves the client to
   derive `<topic>-<subscription>-DLQ`. That holds for both runtimes the rows cover —
   `RetryMessageUtil.getDLQTopic()` is `topic + "-" + subscription + "-DLQ"`, and the Python client
   documents the same default.
   
   I have not rendered the site locally, so the note block and table are checked structurally rather
   than visually.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org