You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/16 19:42:19 UTC
Review Request 71299: Added separate script to install developer
setup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Till Toenshoff.
Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360
Repository: mesos
Description
-------
This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.
Diffs
-----
bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
support/setup_dev.sh PRE-CREATION
Diff: https://reviews.apache.org/r/71299/diff/1/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Aug. 19, 2019, 12:56 p.m., Benno Evers wrote:
> > docs/advanced-contribution.md
> > Line 69 (original), 69 (patched)
> > <https://reviews.apache.org/r/71299/diff/4/?file=2161403#file2161403line69>
> >
> > This became a bit ambiguous now, i.e. is only the second step or the whole step only required if building from git?
> >
> > (also, I'm not sure why we have this qualification at all in a contributors guide)
I agree, removed the part in parentheses (this seems to have appeared with https://reviews.apache.org/r/36472/ w/o much discussion).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217278
-----------------------------------------------------------
On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 1:48 p.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217278
-----------------------------------------------------------
Fix it, then Ship it!
docs/advanced-contribution.md
Line 69 (original), 69 (patched)
<https://reviews.apache.org/r/71299/#comment304575>
This became a bit ambiguous now, i.e. is only the second step or the whole step only required if building from git?
(also, I'm not sure why we have this qualification at all in a contributors guide)
- Benno Evers
On Aug. 19, 2019, 7:19 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 7:19 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217371
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 20, 2019, 11:48 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 11:48 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Aug. 26, 2019, 8:50 p.m., Till Toenshoff wrote:
> > support/setup-dev.sh
> > Lines 29-48 (patched)
> > <https://reviews.apache.org/r/71299/diff/5/?file=2161911#file2161911line29>
> >
> > These still are rather unfortunate, I feel.
This will go away with r/71205.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217434
-----------------------------------------------------------
On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 1:48 p.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217434
-----------------------------------------------------------
Ship it!
Excellent structure - pretty much a move code only review, making it easy for us - Thanks!!
support/setup-dev.sh
Lines 29-48 (patched)
<https://reviews.apache.org/r/71299/#comment304709>
These still are rather unfortunate, I feel.
- Till Toenshoff
On Aug. 20, 2019, 11:48 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 11:48 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217460
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 20, 2019, 4:48 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 4:48 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
-----------------------------------------------------------
(Updated Aug. 20, 2019, 1:48 p.m.)
Review request for mesos, Benno Evers and Till Toenshoff.
Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630
Repository: mesos
Description
-------
This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.
Diffs (updated)
-----
bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
support/setup-dev.sh PRE-CREATION
Diff: https://reviews.apache.org/r/71299/diff/5/
Changes: https://reviews.apache.org/r/71299/diff/4-5/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/
-----------------------------------------------------------
(Updated Aug. 19, 2019, 9:19 a.m.)
Review request for mesos, Benno Evers and Till Toenshoff.
Changes
-------
Rename setup script
Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630
Repository: mesos
Description
-------
This patch breaks the installation of developer tools (i.e., linter
configuration files and git hooks) out of `./bootstrap`. This not only
simplifies and streamlines the setup, but will allow us to add
developer-only features without breaking users who are just interested
in building a distribution tarball.
Diffs (updated)
-----
bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
support/setup-dev.sh PRE-CREATION
Diff: https://reviews.apache.org/r/71299/diff/4/
Changes: https://reviews.apache.org/r/71299/diff/3-4/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 71299: Added separate script to install developer
setup.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71299/#review217264
-----------------------------------------------------------
Fix it, then Ship it!
support/setup_dev.sh
Lines 1 (patched)
<https://reviews.apache.org/r/71299/#comment304566>
Can we name this with a hyphen, `setup-dev.sh`? The majority of the support scripts use hyphen rather than underscore.
support/setup_dev.sh
Lines 7 (patched)
<https://reviews.apache.org/r/71299/#comment304565>
Wrong script name?
- James Peach
On Aug. 16, 2019, 7:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71299/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 7:42 p.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch breaks the installation of developer tools (i.e., linter
> configuration files and git hooks) out of `./bootstrap`. This not only
> simplifies and streamlines the setup, but will allow us to add
> developer-only features without breaking users who are just interested
> in building a distribution tarball.
>
>
> Diffs
> -----
>
> bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c
> bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
> docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c
> docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75
> docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b
> support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b
> support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76
> support/setup_dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71299/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>