You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2013/01/11 06:30:59 UTC
svn commit: r1431896 - in /logging/log4j/log4j2/trunk:
samples/flume-common/src/main/java/org/apache/logging/log4j/samples/app/LoggingController.java
web/src/test/java/org/apache/logging/log4j/core/web/Log4jContextListenerTest.java
Author: ggregory
Date: Fri Jan 11 05:30:59 2013
New Revision: 1431896
URL: http://svn.apache.org/viewvc?rev=1431896&view=rev
Log:
Add final modifier to private fields.
Modified:
logging/log4j/log4j2/trunk/samples/flume-common/src/main/java/org/apache/logging/log4j/samples/app/LoggingController.java
logging/log4j/log4j2/trunk/web/src/test/java/org/apache/logging/log4j/core/web/Log4jContextListenerTest.java
Modified: logging/log4j/log4j2/trunk/samples/flume-common/src/main/java/org/apache/logging/log4j/samples/app/LoggingController.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-common/src/main/java/org/apache/logging/log4j/samples/app/LoggingController.java?rev=1431896&r1=1431895&r2=1431896&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/samples/flume-common/src/main/java/org/apache/logging/log4j/samples/app/LoggingController.java (original)
+++ logging/log4j/log4j2/trunk/samples/flume-common/src/main/java/org/apache/logging/log4j/samples/app/LoggingController.java Fri Jan 11 05:30:59 2013
@@ -46,7 +46,7 @@ public class LoggingController {
private static Logger logger = LogManager.getLogger(LoggingController.class);
private volatile boolean generateLog = false;
- private Random ran = new Random();
+ private final Random ran = new Random();
private List<AuditEvent> events;
Modified: logging/log4j/log4j2/trunk/web/src/test/java/org/apache/logging/log4j/core/web/Log4jContextListenerTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/web/src/test/java/org/apache/logging/log4j/core/web/Log4jContextListenerTest.java?rev=1431896&r1=1431895&r2=1431896&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/web/src/test/java/org/apache/logging/log4j/core/web/Log4jContextListenerTest.java (original)
+++ logging/log4j/log4j2/trunk/web/src/test/java/org/apache/logging/log4j/core/web/Log4jContextListenerTest.java Fri Jan 11 05:30:59 2013
@@ -120,9 +120,9 @@ public class Log4jContextListenerTest {
private class MockServletContext implements ServletContext {
private String name;
- private Hashtable<String, String> params = new Hashtable<String, String>();
+ private final Hashtable<String, String> params = new Hashtable<String, String>();
- private Hashtable<String, Object> attrs = new Hashtable<String, Object>();
+ private final Hashtable<String, Object> attrs = new Hashtable<String, Object>();
public ServletContext getContext(String s) {