You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/05/21 15:57:27 UTC

[kudu-CR] Change all dependency sources to https 

Hello Mike Percy, Dan Burkert, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13390

to review the following change.


Change subject: Change all dependency sources to https
......................................................................

Change all dependency sources to https

Some of our scripts and build tools used to pull dependencies using
unsecured HTTP protocol, changing these to use HTTPS instead for added
security.

Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
---
M README.adoc
M build-support/build_source_release.py
M build-support/release/README.adoc
M java/buildSrc/build.gradle
M java/kudu-jepsen/build.gradle
M thirdparty/package-llvm.sh
M thirdparty/vars.sh
7 files changed, 15 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/13390/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Change all dependency sources to https

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 May 2019 23:14:14 +0000
Gerrit-HasComments: No

[kudu-CR] Change all dependency sources to https

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: Change all dependency sources to https
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Change all dependency sources to https

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13390/1/build-support/build_source_release.py
File build-support/build_source_release.py:

http://gerrit.cloudera.org:8080/#/c/13390/1/build-support/build_source_release.py@148
PS1, Line 148:   rat_url = "https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.13/apache-rat-0.13.jar"
Anything meaningful in this upgrade?



-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 21 May 2019 20:46:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] Change all dependency sources to https

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1: Verified+1

Jenkins failure was an unrelated flake in TSAN


-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 24 May 2019 15:50:23 +0000
Gerrit-HasComments: No

[kudu-CR] Change all dependency sources to https

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 23 May 2019 14:10:11 +0000
Gerrit-HasComments: No

[kudu-CR] Change all dependency sources to https

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................

Change all dependency sources to https

Some of our scripts and build tools used to pull dependencies using
unsecured HTTP protocol, changing these to use HTTPS instead for added
security.

Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Reviewed-on: http://gerrit.cloudera.org:8080/13390
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M README.adoc
M build-support/build_source_release.py
M build-support/release/README.adoc
M java/buildSrc/build.gradle
M java/kudu-jepsen/build.gradle
M thirdparty/package-llvm.sh
M thirdparty/vars.sh
7 files changed, 15 insertions(+), 14 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Mike Percy: Looks good to me, approved
  Grant Henke: Looks good to me, approved
  Attila Bukor: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Change all dependency sources to https

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13390/1/build-support/build_source_release.py
File build-support/build_source_release.py:

http://gerrit.cloudera.org:8080/#/c/13390/1/build-support/build_source_release.py@148
PS1, Line 148:   rat_url = "https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.13/apache-rat-0.13.jar"
> Anything meaningful in this upgrade?
not really, should I revert it to 0.12?



-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 23 May 2019 16:14:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] Change all dependency sources to https

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> (1 comment)

ok. I changed it because I found that the version was inconsistent between the README and the script and thought they should be the same version and decided to go with the latest in this case.


-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 24 May 2019 15:52:11 +0000
Gerrit-HasComments: No

[kudu-CR] Change all dependency sources to https

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13390 )

Change subject: Change all dependency sources to https
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13390/1/build-support/build_source_release.py
File build-support/build_source_release.py:

http://gerrit.cloudera.org:8080/#/c/13390/1/build-support/build_source_release.py@148
PS1, Line 148:   rat_url = "https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.13/apache-rat-0.13.jar"
> not really, should I revert it to 0.12?
Not necessarily. Just saw this as unrelated to your change and wanted to ask for more details.



-- 
To view, visit http://gerrit.cloudera.org:8080/13390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13390
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 23 May 2019 18:28:41 +0000
Gerrit-HasComments: Yes