You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Will Glass-Husain (JIRA)" <ji...@apache.org> on 2010/11/26 17:23:13 UTC

[jira] Created: (SSHD-98) Directories in sftp should have executable permission set

Directories in sftp should have executable permission set
---------------------------------------------------------

                 Key: SSHD-98
                 URL: https://issues.apache.org/jira/browse/SSHD-98
             Project: MINA SSHD
          Issue Type: Improvement
    Affects Versions: 0.5.0
            Reporter: Will Glass-Husain
         Attachments: executable patch.txt

When accessing directories via sftp, the executable bit should be set (for compatibility with linux).

Without it, this causes problems when I use sshfs (a fuse based file system on Linux) to mount the sftp directory as a filesystem.  I can't cd into the directories.

See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (SSHD-98) Directories in sftp should have executable permission set

Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SSHD-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12936051#action_12936051 ] 

Will Glass-Husain edited comment on SSHD-98 at 11/26/10 11:24 AM:
------------------------------------------------------------------

I'm afraid I couldn't figure out how to create a test to check this with jsch.  However, all existing tests pass, and I manually checked this with winscp.  (directories have executable set and other files don't.)

      was (Author: wglass):
    I'm afraid I couldn't figure out how to create a test to check this with jch.  However, all existing tests pass, and I manually checked this with winscp.  (directories have executable set and other files don't.)
  
> Directories in sftp should have executable permission set
> ---------------------------------------------------------
>
>                 Key: SSHD-98
>                 URL: https://issues.apache.org/jira/browse/SSHD-98
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Will Glass-Husain
>         Attachments: executable patch.txt
>
>
> When accessing directories via sftp, the executable bit should be set (for compatibility with linux).
> Without it, this causes problems when I use sshfs (a fuse based file system on Linux) to mount the sftp directory as a filesystem.  I can't cd into the directories.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SSHD-98) Directories in sftp should have executable permission set

Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SSHD-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12936051#action_12936051 ] 

Will Glass-Husain commented on SSHD-98:
---------------------------------------

I'm afraid I couldn't figure out how to create a test to check this with jch.  However, all existing tests pass, and I manually checked this with winscp.  (directories have executable set and other files don't.)

> Directories in sftp should have executable permission set
> ---------------------------------------------------------
>
>                 Key: SSHD-98
>                 URL: https://issues.apache.org/jira/browse/SSHD-98
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Will Glass-Husain
>         Attachments: executable patch.txt
>
>
> When accessing directories via sftp, the executable bit should be set (for compatibility with linux).
> Without it, this causes problems when I use sshfs (a fuse based file system on Linux) to mount the sftp directory as a filesystem.  I can't cd into the directories.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SSHD-98) Directories in sftp should have executable permission set

Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SSHD-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Glass-Husain updated SSHD-98:
----------------------------------

    Attachment: executable patch.txt

> Directories in sftp should have executable permission set
> ---------------------------------------------------------
>
>                 Key: SSHD-98
>                 URL: https://issues.apache.org/jira/browse/SSHD-98
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Will Glass-Husain
>         Attachments: executable patch.txt
>
>
> When accessing directories via sftp, the executable bit should be set (for compatibility with linux).
> Without it, this causes problems when I use sshfs (a fuse based file system on Linux) to mount the sftp directory as a filesystem.  I can't cd into the directories.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SSHD-98) Directories in sftp should have executable permission set

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SSHD-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SSHD-98.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6.0
         Assignee: Guillaume Nodet

Committing to https://svn.apache.org/repos/asf/mina/sshd/trunk ...
	M	sshd-core/src/main/java/org/apache/sshd/server/SshFile.java
	M	sshd-core/src/main/java/org/apache/sshd/server/filesystem/NativeSshFile.java
	M	sshd-core/src/main/java/org/apache/sshd/server/sftp/SftpSubsystem.java
Committed r1039520

The patch is slightly different from yours and try to leverage the canExecute method which has been introduced in JDK 1.6 (and default to isDirectory() if not available).  Could you please double check that it works for you ?

> Directories in sftp should have executable permission set
> ---------------------------------------------------------
>
>                 Key: SSHD-98
>                 URL: https://issues.apache.org/jira/browse/SSHD-98
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Will Glass-Husain
>            Assignee: Guillaume Nodet
>             Fix For: 0.6.0
>
>         Attachments: executable patch.txt
>
>
> When accessing directories via sftp, the executable bit should be set (for compatibility with linux).
> Without it, this causes problems when I use sshfs (a fuse based file system on Linux) to mount the sftp directory as a filesystem.  I can't cd into the directories.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.