[GitHub] [beam] lostluck commented on a change in pull request #15094: [BEAM-12383] Adding Go SDK and Kafka IO to Gradle cross-language test suites.

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #15094:
URL: https://github.com/apache/beam/pull/15094#discussion_r698848265



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -332,6 +332,12 @@ class BeamModulePlugin implements Plugin<Project> {
       "--environment_cache_millis=10000",

Review comment:
       I assume the Go SDK doesn't have this flag to pass through the pipeline options yet. We may want to consider it in the future.

##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -262,22 +262,19 @@ elif [[ "$RUNNER" == "flink" || "$RUNNER" == "spark" || "$RUNNER" == "samza" ||
           --job-port $JOB_PORT \
           --expansion-port 0 \
           --artifact-port 0 &
-      SIMULTANEOUS=1

Review comment:
       I think you need to rebase your PR? Didn't you already merge this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org