You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 16:51:51 UTC
[GitHub] [airflow] potiuk opened a new pull request, #23454: Seperate provider verification as standalone breeze command
potiuk opened a new pull request, #23454:
URL: https://github.com/apache/airflow/pull/23454
This is another step in simplifying and converting to Python all of
the CI/local development tooling.
This PR separates out verification of providers as a separate
breeze command `verify-providers`. It was previously part of
"prepare_provider_packages.py" but it has been now
extracted to a separate in-container python file and it was
wrapped with breeze's `verify-provider` command.
No longer provider verification is run with "preparing provider docs"
nor "preparing provider packages" - it's a standaline command.
This command is also used in CI now to run the tests:
* all provider packages are built and created on CI together with
airflow version
* the packages are installed inside the CI image and providers are
verified
* the 2.1 version of Airflow is installed together with all 2.1
- compatible providers and provider verification is run there too.
This all is much simpler now - we got rediof some 500 lines of bash
code again in favour of breeze python code.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23454: Separate provider verification as standalone breeze command
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23454:
URL: https://github.com/apache/airflow/pull/23454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23454: Separate provider verification as standalone breeze command
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23454:
URL: https://github.com/apache/airflow/pull/23454#issuecomment-1116374155
I looked at generated "help" pages and unified/reshuffled some commands as well (the commands I added are for "power users" and CI mostly so they are moved to "additional options".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23454: Separate provider verification as standalone breeze command
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23454:
URL: https://github.com/apache/airflow/pull/23454#issuecomment-1120060738
Just random failiure. Merging finally !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23454: Seperate provider verification as standalone breeze command
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23454:
URL: https://github.com/apache/airflow/pull/23454#issuecomment-1116331747
~ 500 lines of bash removed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23454: Separate provider verification as standalone breeze command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23454:
URL: https://github.com/apache/airflow/pull/23454#issuecomment-1116360749
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org