You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/05/28 07:45:49 UTC
[GitHub] [hadoop-ozone] flirmnave opened a new pull request #977: HDDS-3673. Version information not printed correctly in SCM WebUI.
flirmnave opened a new pull request #977:
URL: https://github.com/apache/hadoop-ozone/pull/977
## What changes were proposed in this pull request?
Add property in pom so that can get correct version information.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3673
## How was this patch tested?
Run on local docker-compose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #977: HDDS-3673. Version information not printed correctly in SCM WebUI.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #977:
URL: https://github.com/apache/hadoop-ozone/pull/977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #977: HDDS-3673. Version information not printed correctly in SCM WebUI.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #977:
URL: https://github.com/apache/hadoop-ozone/pull/977#discussion_r431674908
##########
File path: pom.xml
##########
@@ -75,6 +75,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<hdds.version>${ozone.version}</hdds.version>
<ozone.version>0.6.0-SNAPSHOT</ozone.version>
<ozone.release>Denali</ozone.release>
+ <declared.hdds.version>${ozone.version}</declared.hdds.version>
Review comment:
Since the property`hdds.version` is also defined, I think this one should reference it instead of `ozone.version`.
```suggestion
<declared.hdds.version>${hdds.version}</declared.hdds.version>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] flirmnave commented on pull request #977: HDDS-3673. Version information not printed correctly in SCM WebUI.
Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #977:
URL: https://github.com/apache/hadoop-ozone/pull/977#issuecomment-635214210
Thanks @adoroszlai for reviewing and I change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org