[jira] Resolved: (WICKET-3173) Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-3173.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4.14

> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
>                 Key: WICKET-3173
>                 URL: https://issues.apache.org/jira/browse/WICKET-3173
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Brian Topping
>            Assignee: Igor Vaynberg
>            Priority: Critical
>             Fix For: 1.4.14
>
>         Attachments: WICKET-3173.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be.  Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value.  But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.  
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.