You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/16 05:53:07 UTC

[GitHub] [pulsar] equanz opened a new pull request #7553: [pulsar-broker] Stop to dispatch manually when skip message temporally since Key_Shared consumer stuck on delivery

equanz opened a new pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553


   ### Motivation
   In some case of Key_Shared consumer, messages ordering was broken.
   Here is how to reproduce(I think it is one of case to reproduce this issue).
   
   1. Connect Consumer1 to Key_Shared subscription `sub` and stop to receive
      - receiverQueueSize: 500
   2. Connect Producer and publish 500 messages with key `(i % 10)`
   3. Connect Consumer2 to same subscription and start to receive
      - receiverQueueSize: 1
      - since https://github.com/apache/pulsar/pull/7106 , Consumer2 can't receive (expected)
   4. Producer publish more 500 messages with same key generation algorithm
   5. After that, Consumer1 start to receive
   6. Check Consumer2 message ordering
      - sometimes message ordering was broken in same key
   
   Consumer1:
   ```
   Connected: Tue Jul 14 09:36:39 JST 2020
   [pulsar-client-io-1-1] WARN com.scurrilous.circe.checksum.Crc32cIntChecksum - Failed to load Circe JNI library. Falling back to Java based CRC32c provider
   [pulsar-timer-4-1] INFO org.apache.pulsar.client.impl.ConsumerStatsRecorderImpl - [persistent://public/default/key-shared-test] [sub0] [820f0] Prefetched messages: 499 --- Consume throughput received: 0.02 msgs/s --- 0.00 Mbit/s --- Ack sent rate: 0.00 ack/s --- Failed messages: 0 --- batch messages: 0 ---Failed acks: 0
   Received: my-message-0 PublishTime: 1594687006203 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-1 PublishTime: 1594687006243 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-2 PublishTime: 1594687006247 Date: Tue Jul 14 09:37:46 JST 2020
   ...
   Received: my-message-498 PublishTime: 1594687008727 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-499 PublishTime: 1594687008731 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-500 PublishTime: 1594687038742 Date: Tue Jul 14 09:37:46 JST 2020
   ...
   Received: my-message-990 PublishTime: 1594687040094 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-994 PublishTime: 1594687040103 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-995 PublishTime: 1594687040105 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-997 PublishTime: 1594687040113 Date: Tue Jul 14 09:37:46 JST 2020
   ```
   
   Consumer2:
   ```
   Connected: Tue Jul 14 09:37:03 JST 2020
   [pulsar-client-io-1-1] WARN com.scurrilous.circe.checksum.Crc32cIntChecksum - Failed to load Circe JNI library. Falling back to Java based CRC32c provider
   Received: my-message-501 MessageId: 4:1501:-1 PublishTime: 1594687038753 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-502 MessageId: 4:1502:-1 PublishTime: 1594687038755 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-503 MessageId: 4:1503:-1 PublishTime: 1594687038759 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-506 MessageId: 4:1506:-1 PublishTime: 1594687038785 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-508 MessageId: 4:1508:-1 PublishTime: 1594687038812 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-901 MessageId: 4:1901:-1 PublishTime: 1594687039871 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-509 MessageId: 4:1509:-1 PublishTime: 1594687038815 Date: Tue Jul 14 09:37:46 JST 2020
   ordering was broken, key: 1 oldNum: 901 newNum: 511
   Received: my-message-511 MessageId: 4:1511:-1 PublishTime: 1594687038826 Date: Tue Jul 14 09:37:46 JST 2020
   Received: my-message-512 MessageId: 4:1512:-1 PublishTime: 1594687038830 Date: Tue Jul 14 09:37:46 JST 2020
   ...
   ```
   
   I think this issue is caused by https://github.com/apache/pulsar/pull/7105.
   Here is example.
   1. dispatch messages
   2. Consumer2 was stuck and `totalMessagesSent=0`
      - Consumer2 availablePermits was 0
   3. skip redeliver messages temporally
      - Consumer2 availablePermits was back to 1
   4. dispatch new messages
      - new message was dispatched to Consumer2
   5. back to redeliver messages
   4. dispatch messages
      - ordering was broken
   
   ### Modifications
   Stop to dispatch manually when skip message temporally since Key_Shared consumer stuck on delivery.
   
   ### Verifying this change
   It seems that this issue should check in some test cases.
   However, I think this issue is corner case and not easier to check. If it is not, please tell me.
   
   ### Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie edited a comment on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie edited a comment on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-664745375


   @equanz
   Thanks for checking.
   I'm not sure why but the not-consuming issue can't be reproduced for some reason.
   So now I can consume messages.
   
   I also re-tested and still see NG.
   Can you try several times ?
   Sometimes it doesn't occur but it does most of the time.
   
   Regarding the debug log, sorry I'm not sure how to enable debug log in Pulsar.
   I updated `conf/log4j2.yaml` status to `DEBUG` from `INFO`, but it doesn't seem to be logging with `DEBUG`.
   So I don't see the `stuckConsumers` message yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-662432844


   I've checked this PR with the procedure in #7455 to see if there are any out-of-order messages.
   But now consumers don't even consume anything.
   The same thing happens for pulsar-perf so I don't think it's the issue of the procedure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-668386512


   @equanz Hmm, that is pretty weird.
   It happens to me 9 out of 10.
   The cause of #7455 seems like the number of consumers are changing (increasing) during consuming,
   but is it the case for your testing ? 
   (Sorry my procedures to reproduce is a bit not correct.
   I added step 3 to register subscriptions beforehand.
   https://github.com/feeblefakie/misc/blob/master/pulsar/HOW-TO-REPRODUCE.md )
   
   If I start consumers before producers, the issue won't happen since the number of consumers is constant.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie edited a comment on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie edited a comment on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-664745375


   @equanz
   Thanks for checking.
   I'm not sure why but the not-consuming issue can't be reproduced for some reason.
   So now I can consume messages.
   
   I also re-tested and still see NG.
   Can you try several times ?
   Sometimes it doesn't occur but it does most of the time.
   
   Regarding the debug log, sorry I'm not sure how to enable debug log in Pulsar.
   I updated `conf/log4j2.yaml` status to `DEBUG` from `INFO`, but it doesn't see to be logging with `DEBUG`.
   So I don't see the `stuckConsumers` message yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-671756005


   @codelipenghui can you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-664125696


   @feeblefakie Thank you for your check. But I couldn't reproduce your issue (my procedure below) now. Is [this debug log](https://github.com/apache/pulsar/pull/7553/files#diff-8f773b51748a5cb5f7a298a4f65d1134R264) occurred in your standalone? Or please tell me more detail.
   
   test procedure
   1. build this code
   2. start standalone with `--wipe-data` and default config (so, use `AUTO_SPLIT`)
   3. create partitioned topic with 32 partition
   4. create subscription `sub0`, and `sub1` as latest position to same topic
   5. produce messages with your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyProducer.java)
   6. consume messages as `sub0` with your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyConsumer.java)
      - out: 10000 records
   7. consume messages as `sub1` with your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyConsumer.java)
      - out: 10000 records
   8. check output with your [script](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/check.sh)
   
   and no `NG` was found(with 1000 `OK`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-670647133


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-674613175


   @codelipenghui Added unit test to broker side. So, please take another look.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-668446473


   > The cause of #7455 seems like the number of consumers are changing (increasing) during consuming,
   but is it the case for your testing ?
   
   I think my issue is occurred by some consumers with different throughput in same subscription.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-669633825


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch manually when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-660467022


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz edited a comment on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz edited a comment on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-668353695


   Sorry to be late.
   
   > I also re-tested and still see NG.
   Can you try several times ?
   Sometimes it doesn't occur but it does most of the time.
   
   Try to check 7 times but I couldn't reproduce this issue.
   I think https://github.com/apache/pulsar/issues/7455 possibly be another issue...
   
   > Regarding the debug log, sorry I'm not sure how to enable debug log in Pulsar.
   
   Here is an example. I thought try to check not-consuming issue by this log.
   ```
   diff --git a/conf/log4j2.yaml b/conf/log4j2.yaml
   index 34826740ca..b4dc4dabbb 100644
   --- a/conf/log4j2.yaml
   +++ b/conf/log4j2.yaml
   @@ -151,6 +151,11 @@ Configuration:
            AppenderRef:
              - ref: Console
   
   +      - name: org.apache.pulsar.broker.service.persistent.PersistentStickyKeyDispatcherMultipleConsumers
   +        level: debug
   +        AppenderRef:
   +          - ref: Console
   +
        # Logger to inject filter script
    #     - name: org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl
    #       level: debug
   ```
   
   > I'm not sure why but the not-consuming issue can't be reproduced for some reason.
   
   I understand. If not-consuming issue is caused by this issue, I must fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-662426664


   I've check the procedure described in #7455 with equanz:stop_to_dispatch_manually_key_shared.
   This time, consumers got to not consuming any messages now. Seems just stuck.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-669846726


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie removed a comment on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie removed a comment on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-662426664


   I've check the procedure described in #7455 with equanz:stop_to_dispatch_manually_key_shared.
   This time, consumers got to not consuming any messages now. Seems just stuck.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz edited a comment on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz edited a comment on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-664125696


   @feeblefakie Thank you for your check. But I couldn't reproduce your issue (my procedure below) now. Is [this debug log](https://github.com/apache/pulsar/pull/7553/files#diff-8f773b51748a5cb5f7a298a4f65d1134R264) occurred in your standalone? Or please tell me more detail.
   
   test procedure
   1. build this code
   2. start standalone with `--wipe-data` and default config (so, use `AUTO_SPLIT`)
   3. create partitioned topic with 32 partition
   4. create subscription `sub0`, and `sub1` as latest position to same topic
   5. produce messages by your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyProducer.java)
   6. consume messages as `sub0` by your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyConsumer.java)
      - out: 10000 records
   7. consume messages as `sub1` by your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyConsumer.java)
      - out: 10000 records
   8. check output by your [script](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/check.sh)
   
   and no `NG` was found(with 1000 `OK`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-674890161


   @equanz Thanks a lot, I will take a look soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz edited a comment on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz edited a comment on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-664125696


   @feeblefakie Thank you for your check. But I couldn't reproduce your issue (my procedure below) now. Is [this debug log](https://github.com/apache/pulsar/pull/7553/files#diff-8f773b51748a5cb5f7a298a4f65d1134R264) occurred in your standalone? Or please tell me more detail.
   
   test procedure
   1. build this code
   2. start standalone with `--wipe-data` and default config (so, use `AUTO_SPLIT`)
   3. create partitioned topic with 32 partition
   4. create subscription `sub0`, and `sub1` as latest position to same topic
   5. produce messages with your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyProducer.java)
   6. consume messages as `sub0` by your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyConsumer.java)
      - out: 10000 records
   7. consume messages as `sub1` by your [code](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/src/main/java/MyConsumer.java)
      - out: 10000 records
   8. check output by your [script](https://github.com/feeblefakie/misc/blob/ed6439c596227eace6ce7176d93424fa35d34406/pulsar/check.sh)
   
   and no `NG` was found(with 1000 `OK`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-672851610


   @equanz Is it possible to add a unit test? so that we can better understand the problem and make sure it is fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] feeblefakie commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
feeblefakie commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-664745375


   @equanz
   Thanks for checking.
   I'm not sure why but the not-consuming issue can't be reproduced for some reason.
   So now I can consume messages.
   
   I also re-tested and still see NG.
   Can you try several times ?
   Sometimes it doesn't occur but it does most of the time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-668353695


   Sorry to be late.
   
   > I also re-tested and still see NG.
   Can you try several times ?
   Sometimes it doesn't occur but it does most of the time.
   
   Try to check 7 times but I couldn't reproduce this issue.
   I think https://github.com/apache/pulsar/issues/7455 possibly be another issue...
   
   > Regarding the debug log, sorry I'm not sure how to enable debug log in Pulsar.
   
   Here is an example. I thought try to check not-consuming issue by this log.
   ```
   diff --git a/conf/log4j2.yaml b/conf/log4j2.yaml
   index 34826740ca..b4dc4dabbb 100644
   --- a/conf/log4j2.yaml
   +++ b/conf/log4j2.yaml
   @@ -151,6 +151,11 @@ Configuration:
            AppenderRef:
              - ref: Console
   
   +      - name: org.apache.pulsar.broker.service.persistent.PersistentStickyKeyDispatcherMultipleConsumers
   +        level: debug
   +        AppenderRef:
   +          - ref: Console
   +
        # Logger to inject filter script
    #     - name: org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl
    #       level: debug
   ```
   
   > I'm not sure why but the not-consuming issue can't be reproduced for some reason.
   
   I understand. If this issue is caused by this issue, I must fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] equanz commented on pull request #7553: [pulsar-broker] Stop to dispatch when skip message temporally since Key_Shared consumer stuck on delivery

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #7553:
URL: https://github.com/apache/pulsar/pull/7553#issuecomment-673207185


   @codelipenghui I understand. As stated above, I think this issue is corner case and probably not easier to check.
   But I'll try to add some tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org