[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #20593: [Chore](runtime filter) remove runtime filter ready_for_publish/publish_finally

["BiteTheDDDDt (via GitHub)" <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #20593:
URL: https://github.com/apache/doris/pull/20593#discussion_r1226124034


##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -196,29 +197,33 @@ class RuntimeFilterSlotsBase {
         }
     }
 
-    // should call this method after insert
-    void ready_for_publish() {
+    bool read_finish_publish() {

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org