You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "punish-yh (via GitHub)" <gi...@apache.org> on 2023/09/01 08:25:39 UTC
[GitHub] [hudi] punish-yh opened a new pull request, #9597: make SimpleAvroKeyGenerator support multi partition key
punish-yh opened a new pull request, #9597:
URL: https://github.com/apache/hudi/pull/9597
### Change Logs
make SimpleAvroKeyGenerator support multi partition key
### Impact
_Describe any public API or user-facing feature change or any performance impact._
No, this change is forward compatibility
### Risk level (write none, low medium or high below)
NO
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
NO
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1715868498
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
}, {
"hash" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857",
"triggerID" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"triggerType" : "PUSH"
}, {
"hash" : "e65d1d55bdf960170a168a52e503c72f8620c6bf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e65d1d55bdf960170a168a52e503c72f8620c6bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23fca27a54fc3f0308fe290827dc9ef61646b39b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605)
* a6b67ff8f6526890a2935da7879c6a4c5a8647d9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857)
* e65d1d55bdf960170a168a52e503c72f8620c6bf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1715577293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
}, {
"hash" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857",
"triggerID" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23fca27a54fc3f0308fe290827dc9ef61646b39b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605)
* a6b67ff8f6526890a2935da7879c6a4c5a8647d9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1702804892
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23fca27a54fc3f0308fe290827dc9ef61646b39b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1702424717
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23fca27a54fc3f0308fe290827dc9ef61646b39b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1715563245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
}, {
"hash" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23fca27a54fc3f0308fe290827dc9ef61646b39b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605)
* a6b67ff8f6526890a2935da7879c6a4c5a8647d9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1702437843
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23fca27a54fc3f0308fe290827dc9ef61646b39b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make SimpleAvroKeyGenerator support multi partition key [hudi]
Posted by "punish-yh (via GitHub)" <gi...@apache.org>.
punish-yh closed pull request #9597: make SimpleAvroKeyGenerator support multi partition key
URL: https://github.com/apache/hudi/pull/9597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "pratyakshsharma (via GitHub)" <gi...@apache.org>.
pratyakshsharma commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1716905001
This change is probably not needed. Let me circle back on this in a while @punish-yh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9597:
URL: https://github.com/apache/hudi/pull/9597#discussion_r1314488641
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/SimpleAvroKeyGenerator.java:
##########
@@ -41,7 +43,10 @@ public SimpleAvroKeyGenerator(TypedProperties props) {
SimpleAvroKeyGenerator(TypedProperties props, Option<String> recordKeyField, String partitionPathField) {
super(props);
this.recordKeyFields = recordKeyField.map(keyField -> Collections.singletonList(keyField)).orElse(Collections.emptyList());
- this.partitionPathFields = Collections.singletonList(partitionPathField);
+ this.partitionPathFields = Arrays.stream(partitionPathField.split(","))
Review Comment:
We can add some basic UTs for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] punish-yh commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "punish-yh (via GitHub)" <gi...@apache.org>.
punish-yh commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1702373463
@danny0405 please review this pr with https://github.com/apache/hudi/issues/9587 issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] punish-yh commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "punish-yh (via GitHub)" <gi...@apache.org>.
punish-yh commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1716852924
I found CI was failure for other UT, should I do something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1715949489
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
}, {
"hash" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857",
"triggerID" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"triggerType" : "PUSH"
}, {
"hash" : "e65d1d55bdf960170a168a52e503c72f8620c6bf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19868",
"triggerID" : "e65d1d55bdf960170a168a52e503c72f8620c6bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6b67ff8f6526890a2935da7879c6a4c5a8647d9 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857)
* e65d1d55bdf960170a168a52e503c72f8620c6bf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19868)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1716064947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19605",
"triggerID" : "23fca27a54fc3f0308fe290827dc9ef61646b39b",
"triggerType" : "PUSH"
}, {
"hash" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19857",
"triggerID" : "a6b67ff8f6526890a2935da7879c6a4c5a8647d9",
"triggerType" : "PUSH"
}, {
"hash" : "e65d1d55bdf960170a168a52e503c72f8620c6bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19868",
"triggerID" : "e65d1d55bdf960170a168a52e503c72f8620c6bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e65d1d55bdf960170a168a52e503c72f8620c6bf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19868)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #9597: make SimpleAvroKeyGenerator support multi partition key
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #9597:
URL: https://github.com/apache/hudi/pull/9597#issuecomment-1716931542
@pratyakshsharma Thanks so much for the review ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org