You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/11 08:56:37 UTC
[GitHub] [spark] danielhaviv opened a new pull request, #37153: [SPARK-26052] Add type comments to exposed Prometheus metrics
danielhaviv opened a new pull request, #37153:
URL: https://github.com/apache/spark/pull/37153
### What changes were proposed in this pull request?
Add a `# TYPE` comment for every exposed Prometheus metric
### Why are the changes needed?
According to [Prometheus' exposition format](https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md), a type comment is expected before every metric.
The PrometheusServlet exposed the metrics with types as lables, which is not in accordance with the expected format.
This causes tools such Cloudwatch agent to treat such metrics as untyped and discard them.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Manually tested by letting CloudWatch agent scrape the Prometheus endpoint of a modified spark driver.
All metrics reported with a type, which were previously discarded, have been added to CW:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37153: [SPARK-26052] Add type comments to exposed Prometheus metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37153: [SPARK-26052] Add type comments to exposed Prometheus metrics
URL: https://github.com/apache/spark/pull/37153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ebarault commented on pull request #37153: [SPARK-26052] Add type comments to exposed Prometheus metrics
Posted by "ebarault (via GitHub)" <gi...@apache.org>.
ebarault commented on PR #37153:
URL: https://github.com/apache/spark/pull/37153#issuecomment-1462161162
@danielhaviv hi, it looks like your PR was left untouched by the spark team... 👎
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-26052] Add type comments to exposed Prometheus metrics [spark]
Posted by "VincentRoest (via GitHub)" <gi...@apache.org>.
VincentRoest commented on PR #37153:
URL: https://github.com/apache/spark/pull/37153#issuecomment-1776857024
Please reopen, this is a very much wanted feature. Cloudwatch Agent is hardwired to use this + indeed the current way the metrics are exposed is not conform to Prometheus' standards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37153: [SPARK-26052] Add type comments to exposed Prometheus metrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37153:
URL: https://github.com/apache/spark/pull/37153#issuecomment-1181262208
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37153: [SPARK-26052] Add type comments to exposed Prometheus metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37153:
URL: https://github.com/apache/spark/pull/37153#issuecomment-1286306398
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org