You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/25 07:19:32 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #5695: [INLONG-5694][Manager] Click to view the group info of initsort execution failure and report an error
fuweng11 opened a new pull request, #5695:
URL: https://github.com/apache/inlong/pull/5695
### Prepare a Pull Request
- Fixes #5694
### Motivation
Make sure the group information of initsort failure can be viewed normally
### Modifications
This ensures that no null pointer exception will be reported when getting the sort configuration information.
### Verifying this change
*(Please pick either of the following options)*
- [X] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leosanqing commented on pull request #5695: [INLONG-5694][Manager] Fix the problem that gets the inlong group error
Posted by GitBox <gi...@apache.org>.
leosanqing commented on PR #5695:
URL: https://github.com/apache/inlong/pull/5695#issuecomment-1227178116
I find this article，They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5695: [INLONG-5694][Manager] Fix the problem that gets the inlong group error
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5695:
URL: https://github.com/apache/inlong/pull/5695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leosanqing commented on pull request #5695: [INLONG-5694][Manager] Fix the problem that gets the inlong group error
Posted by GitBox <gi...@apache.org>.
leosanqing commented on PR #5695:
URL: https://github.com/apache/inlong/pull/5695#issuecomment-1227978983
> I find this article，They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values
>
>  I don't think it's necessary to force the stream function to make the code hard to read.
Yes, that article just tells why the NPE occurs, and then provides a workaround.
It's not mandatory, nor necessary, that kind of performance is bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on pull request #5695: [INLONG-5694][Manager] Fix the problem that gets the inlong group error
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on PR #5695:
URL: https://github.com/apache/inlong/pull/5695#issuecomment-1227967029
> > I find this article，They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values
> > 
> > I don't think it's necessary to force the stream function to make the code hard to read.
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on pull request #5695: [INLONG-5694][Manager] Fix the problem that gets the inlong group error
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on PR #5695:
URL: https://github.com/apache/inlong/pull/5695#issuecomment-1226992328
suggest searching for similar code snippets in case there are more like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on pull request #5695: [INLONG-5694][Manager] Fix the problem that gets the inlong group error
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on PR #5695:
URL: https://github.com/apache/inlong/pull/5695#issuecomment-1227962272
> I find this article，They gave a solution, I tried it and it works: https://stackoverflow.com/questions/24630963/nullpointerexception-in-collectors-tomap-with-null-entry-values
>
> 
I don't think it's necessary to force the stream function to make the code hard to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org