[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation

["Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614548#action_12614548 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-78:
-------------------------------------------------

This is a nice implementation, James. Good job! My two comments are:

1- It might be a good idea to throw the exceptions instead of trying to catch them and retry. You will end up with a cleaner code;
2- I'm not sure if it is necessary to add the log4j configuration. Is there a particular reason for including it or it is there by accident?



> added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-78
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: james strachan
>            Assignee: james strachan
>         Attachments: writeLock_protocol.patch
>
>
> Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.