You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by bo...@apache.org on 2022/12/25 20:00:38 UTC

[streampipes] 06/06: add checkstyle to streampipes-performance-tests

This is an automated email from the ASF dual-hosted git repository.

bossenti pushed a commit to branch chore/add-checkstyle
in repository https://gitbox.apache.org/repos/asf/streampipes.git

commit d9c16b15ac905dd8d6571b564a045e27c200913c
Author: bossenti <bo...@posteo.de>
AuthorDate: Sun Dec 25 21:00:04 2022 +0100

    add checkstyle to streampipes-performance-tests
---
 streampipes-performance-tests/pom.xml                 | 13 +++++++++++--
 .../performance/PipelinePerformanceTest.java          |  8 +++-----
 .../performance/dataprovider/JsonDataProvider.java    |  9 +++++----
 .../dataprovider/SimpleSchemaProvider.java            |  7 ++++---
 .../performance/model/PerformanceTestSettings.java    |  4 +++-
 .../performance/simulation/SimulationManager.java     | 17 +++++++++--------
 .../tests/serializer/JsonSerializerTest.java          | 19 ++++++++++---------
 .../streampipes/performance/util/ParameterTool.java   |  2 +-
 8 files changed, 46 insertions(+), 33 deletions(-)

diff --git a/streampipes-performance-tests/pom.xml b/streampipes-performance-tests/pom.xml
index da9539a77..49c1271c8 100644
--- a/streampipes-performance-tests/pom.xml
+++ b/streampipes-performance-tests/pom.xml
@@ -17,7 +17,8 @@
   ~
   -->
 
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <parent>
         <artifactId>streampipes-parent</artifactId>
         <groupId>org.apache.streampipes</groupId>
@@ -52,4 +53,12 @@
 
         <!-- External dependencies -->
     </dependencies>
-</project>
\ No newline at end of file
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+            </plugin>
+        </plugins>
+    </build>
+</project>
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/PipelinePerformanceTest.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/PipelinePerformanceTest.java
index 0f6422a5c..703b6e299 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/PipelinePerformanceTest.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/PipelinePerformanceTest.java
@@ -35,9 +35,9 @@ public class PipelinePerformanceTest {
 
   public static void main(String[] args) {
     if (args.length < 6) {
-      System.out.println("Usage: java -jar streampipes-performance-tests.jar [NUMBER OF TIMESTAMP ENRICH EPAS] " +
-              "[PARALELLISM OF ENRICHMENT EPAS], [PARALELLISM OF ELASTIC EPAs], [TOTAL NUMBER OF EVENTS], [WAIT TIME " +
-              "BETWEEN EVENTS], [NUMBER OF PRODUCER THREADS]");
+      System.out.println("Usage: java -jar streampipes-performance-tests.jar [NUMBER OF TIMESTAMP ENRICH EPAS] "
+          + "[PARALELLISM OF ENRICHMENT EPAS], [PARALELLISM OF ELASTIC EPAs], [TOTAL NUMBER OF EVENTS], [WAIT TIME "
+          + "BETWEEN EVENTS], [NUMBER OF PRODUCER THREADS]");
     } else {
       PerformanceTestSettings settings = ParameterTool.fromArgs(args);
 
@@ -54,6 +54,4 @@ public class PipelinePerformanceTest {
   //Kafka Publisher
 
 
-
-
 }
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/JsonDataProvider.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/JsonDataProvider.java
index 677bdc5b6..3dbd81111 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/JsonDataProvider.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/JsonDataProvider.java
@@ -18,13 +18,14 @@
 
 package org.apache.streampipes.performance.dataprovider;
 
-import com.google.gson.JsonElement;
-import com.google.gson.JsonObject;
-import org.apache.commons.lang3.RandomStringUtils;
-import org.apache.streampipes.model.schema.EventSchema;
 import org.apache.streampipes.model.schema.EventProperty;
 import org.apache.streampipes.model.schema.EventPropertyList;
 import org.apache.streampipes.model.schema.EventPropertyPrimitive;
+import org.apache.streampipes.model.schema.EventSchema;
+
+import com.google.gson.JsonElement;
+import com.google.gson.JsonObject;
+import org.apache.commons.lang3.RandomStringUtils;
 
 import java.util.ArrayList;
 import java.util.List;
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/SimpleSchemaProvider.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/SimpleSchemaProvider.java
index 3c604fe70..df060d59c 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/SimpleSchemaProvider.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/dataprovider/SimpleSchemaProvider.java
@@ -18,10 +18,11 @@
 
 package org.apache.streampipes.performance.dataprovider;
 
-import org.apache.commons.lang3.RandomStringUtils;
-import org.apache.streampipes.model.schema.EventSchema;
 import org.apache.streampipes.model.schema.EventProperty;
 import org.apache.streampipes.model.schema.EventPropertyPrimitive;
+import org.apache.streampipes.model.schema.EventSchema;
+
+import org.apache.commons.lang3.RandomStringUtils;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -34,7 +35,7 @@ public class SimpleSchemaProvider {
   public EventSchema getSchema() {
     EventSchema schema = new EventSchema();
     List<EventProperty> properties = new ArrayList<>();
-    for(int i = 0; i < 5; i++) {
+    for (int i = 0; i < 5; i++) {
       properties.add(makeRandomProperty());
     }
 
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/model/PerformanceTestSettings.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/model/PerformanceTestSettings.java
index 63e814bbe..d06836d21 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/model/PerformanceTestSettings.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/model/PerformanceTestSettings.java
@@ -37,7 +37,9 @@ public class PerformanceTestSettings {
   private Integer numProducerThreads;
   private String elasticUrl;
 
-  public PerformanceTestSettings(Integer numberOfTimestampEnrichmentEpas, Integer parallelismOfEnrichmentEpas, Integer parallelismOfElasticEpas, Long totalNumberofEvents, Long waitTimeBetweenEventsInMs, Integer numProducerThreads, String elasticUrl) {
+  public PerformanceTestSettings(Integer numberOfTimestampEnrichmentEpas, Integer parallelismOfEnrichmentEpas,
+                                 Integer parallelismOfElasticEpas, Long totalNumberofEvents,
+                                 Long waitTimeBetweenEventsInMs, Integer numProducerThreads, String elasticUrl) {
     this.numberOfTimestampEnrichmentEpas = numberOfTimestampEnrichmentEpas;
     this.parallelismOfEnrichmentEpas = parallelismOfEnrichmentEpas;
     this.parallelismOfElasticEpas = parallelismOfElasticEpas;
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/simulation/SimulationManager.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/simulation/SimulationManager.java
index 0380ff183..bc68c9942 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/simulation/SimulationManager.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/simulation/SimulationManager.java
@@ -17,10 +17,11 @@
  */
 package org.apache.streampipes.performance.simulation;
 
-import org.apache.commons.lang3.RandomStringUtils;
 import org.apache.streampipes.performance.model.PerformanceTestSettings;
 import org.apache.streampipes.performance.producer.DataSimulator;
 
+import org.apache.commons.lang3.RandomStringUtils;
+
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -45,24 +46,24 @@ public class SimulationManager {
 
     List<Thread> threads = new ArrayList<>();
 
-    for(Integer i = 0; i < settings.getNumProducerThreads(); i++) {
+    for (Integer i = 0; i < settings.getNumProducerThreads(); i++) {
       String threadId = RandomStringUtils.randomAlphanumeric(6);
       statusMap.put(threadId, false);
       threads.add(new Thread(new DataSimulator(kafkaUrl, settings.getTotalNumberofEvents(), settings
-              .getWaitTimeBetweenEventsInMs(), threadId, threadId1 -> {
-                statusMap.put(threadId1, true);
-                checkFinished();
-              })));
+          .getWaitTimeBetweenEventsInMs(), threadId, threadId1 -> {
+        statusMap.put(threadId1, true);
+        checkFinished();
+      })));
     }
 
-    for(Thread thread : threads) {
+    for (Thread thread : threads) {
       thread.start();
     }
   }
 
   private void checkFinished() {
     if (statusMap.keySet().stream().allMatch(key -> statusMap.get(key))) {
-     notifier.onFinished();
+      notifier.onFinished();
     }
   }
 }
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/tests/serializer/JsonSerializerTest.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/tests/serializer/JsonSerializerTest.java
index 39782dd1b..8f6b67bbe 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/tests/serializer/JsonSerializerTest.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/tests/serializer/JsonSerializerTest.java
@@ -18,13 +18,14 @@
 
 package org.apache.streampipes.performance.tests.serializer;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.apache.streampipes.commons.exceptions.SpRuntimeException;
 import org.apache.streampipes.dataformat.json.JsonDataFormatDefinition;
 import org.apache.streampipes.performance.dataprovider.JsonDataProvider;
 import org.apache.streampipes.performance.dataprovider.SimpleSchemaProvider;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -38,10 +39,10 @@ public class JsonSerializerTest {
     List<Map<String, Object>> events = new ArrayList<>();
     JsonDataFormatDefinition formatter = new JsonDataFormatDefinition();
 
-    LOG.info("Total events: " +data.size());
+    LOG.info("Total events: " + data.size());
     LOG.info("Starting deserializer test");
     Long startTime = System.currentTimeMillis();
-    for(String item : data) {
+    for (String item : data) {
       try {
         events.add(formatter.toMap(item.getBytes()));
       } catch (SpRuntimeException e) {
@@ -50,12 +51,12 @@ public class JsonSerializerTest {
     }
     Long endTime = System.currentTimeMillis();
 
-    LOG.info("Total time: " +String.valueOf(endTime - startTime));
-    LOG.info("Per event: " +String.valueOf((endTime - startTime)/data.size()));
+    LOG.info("Total time: " + String.valueOf(endTime - startTime));
+    LOG.info("Per event: " + String.valueOf((endTime - startTime) / data.size()));
 
     LOG.info("Starting serializer test");
     startTime = System.currentTimeMillis();
-    for(Map<String, Object> event : events) {
+    for (Map<String, Object> event : events) {
       try {
         formatter.fromMap(event);
       } catch (SpRuntimeException e) {
@@ -64,7 +65,7 @@ public class JsonSerializerTest {
     }
     endTime = System.currentTimeMillis();
 
-    LOG.info("Total time: " +String.valueOf(endTime - startTime));
-    LOG.info("Per event: " +String.valueOf((endTime - startTime)/data.size()));
+    LOG.info("Total time: " + String.valueOf(endTime - startTime));
+    LOG.info("Per event: " + String.valueOf((endTime - startTime) / data.size()));
   }
 }
diff --git a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/util/ParameterTool.java b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/util/ParameterTool.java
index 4c8976189..bca098b63 100644
--- a/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/util/ParameterTool.java
+++ b/streampipes-performance-tests/src/main/java/org/apache/streampipes/performance/util/ParameterTool.java
@@ -23,7 +23,7 @@ public class ParameterTool {
 
   public static PerformanceTestSettings fromArgs(String[] args) {
     return new PerformanceTestSettings(toInt(args[0]), toInt(args[1]), toInt(args[2]), toLong(args[3]), toLong
-            (args[4]), toInt(args[5]), args[6]);
+        (args[4]), toInt(args[5]), args[6]);
   }
 
   private static Long toLong(String arg) {