[jira] [Comment Edited] (YUNIKORN-2335) Use go standard library min and max functions

["Chia-Ping Tsai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812300#comment-17812300 ] 

Chia-Ping Tsai edited comment on YUNIKORN-2335 at 1/30/24 1:06 PM:
-------------------------------------------------------------------

the go version of k8shim was updated from 1.20 to 1.21 by [https://github.com/apache/yunikorn-k8shim/commit/12c3908d92f6e1f9903ebbec1b107c9722ea3273]


was (Author: chia7712):
the go version was updated from 1.20 to 1.21 by [https://github.com/apache/yunikorn-k8shim/commit/12c3908d92f6e1f9903ebbec1b107c9722ea3273]

> Use go standard library min and max functions
> ---------------------------------------------
>
>                 Key: YUNIKORN-2335
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2335
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - common
>            Reporter: Wilfred Spiegelenburg
>            Assignee: GeordieMai
>            Priority: Major
>              Labels: newbie
>
> Go 1.21 introduced standard min and max builtin functions.
> We should remove the following functions:
>  * MaxQuantity (resources)
>  * MinQuantity (resources)
>  * min (ring buffer)
>  * Min (common utils)
> Replace with min and max builtin functions.
> NOTE: this requires a go directive change in the go.mod file to move to 1.21 as the minimum version. This needs to be coordinates for the different repos.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org