You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Sergey Dudoladov (JIRA)" <ji...@apache.org> on 2015/10/29 12:14:27 UTC
[jira] [Comment Edited] (REEF-833) Create unit test for heartbeats
to prove that they happen in order
[ https://issues.apache.org/jira/browse/REEF-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980274#comment-14980274 ]
Sergey Dudoladov edited comment on REEF-833 at 10/29/15 11:14 AM:
------------------------------------------------------------------
It might be that the older version (as of commit {{b459aafd8f729b2db4e1de67ed8672d7ebe8615b}}) of the {{HeartBeatManager.java}} asked to test the order of the items in the {{contextStatusList}}:
{code}
// TODO: Write a test that checks for the order.
final Collection<ReefServiceProtos.ContextStatusProto> contextStatusList = new ArrayList<>();
contextStatusList.add(contextStatusProto);
contextStatusList.addAll(this.contextManager.get().getContextStatusCollection());
{code}
I guess the initial intent was to ensure that the order of {{contextStatusProto}} objects in {{contextStatusList}} corresponds to the order of Contexts in the context stack of the evaluator, and that both driver and evaluator assume the same order of context statuses.
The current version explicitly asks for the order of heartbeats:
{code}
// TODO[JIRA REEF-833]: Write a test that verifies correct order of heartbeats.
{code}
Can please anyone clarify ?
was (Author: dss-2009@yandex.ru):
It might be that the older version (commit {{b459aafd8f729b2db4e1de67ed8672d7ebe8615b}}) of the {{HeartBeatManager.java}} asked to test the order of the items in the {{contextStatusList}}:
{code}
// TODO: Write a test that checks for the order.
final Collection<ReefServiceProtos.ContextStatusProto> contextStatusList = new ArrayList<>();
contextStatusList.add(contextStatusProto);
contextStatusList.addAll(this.contextManager.get().getContextStatusCollection());
{code}
I guess the initial intent was to ensure that the order of {{contextStatusProto}} objects in {{contextStatusList}} corresponds to the order of Contexts in the context stack of the evaluator, and that both driver and evaluator assume the same order of context statuses.
The current version explicitly asks for the order of heartbeats:
{code}
// TODO[JIRA REEF-833]: Write a test that verifies correct order of heartbeats.
{code}
Can please anyone clarify ?
> Create unit test for heartbeats to prove that they happen in order
> ------------------------------------------------------------------
>
> Key: REEF-833
> URL: https://issues.apache.org/jira/browse/REEF-833
> Project: REEF
> Issue Type: Task
> Components: REEF-Common
> Reporter: Mariia Mykhailova
>
> {{org.apache.reef.runtime.common.evaluator.HeartBeatManager}}
> We need a unit test for the heartbeats which ensures that they happen in order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)