You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/31 13:31:36 UTC

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #952: Make JDBC OSGi usable and added a feature file

jixuan1989 commented on a change in pull request #952: Make JDBC OSGi usable and added a feature file
URL: https://github.com/apache/incubator-iotdb/pull/952#discussion_r400915354
 
 

 ##########
 File path: hadoop/pom.xml
 ##########
 @@ -49,6 +49,61 @@
     </dependencies>
     <build>
         <plugins>
+            <!--
+        Generate an OSGI compatible MANIFEST file.
+      -->
+            <plugin>
 
 Review comment:
   I think the tsfile and service-rpc pom files are modified because the two modules are dependent by jdbc.
   But why this Hadoop pom is also modified?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services