[GitHub] [pulsar-client-go] Gleiphir2769 commented on issue #183: support Cumulative ack

[GitBox <gi...@apache.org>]

Gleiphir2769 commented on issue #183:
URL: https://github.com/apache/pulsar-client-go/issues/183#issuecomment-1339387402

   Hi, @merlimat , I think comulative ack needs to be supported in go client.
   
   > Cumulative ack doesn't provide much more performance/effciency
   
   You are right. cumulative ack does not more performance. But the need to support this feature stems more from simplifying code logic for user.
   
   > In our scenario, we use a chan to handle all message. If one ack failed(in current pulsar go client ack didn't throw error, I saw some pr is fixing it), what is the expected behaviour?
   Do we need to keep all the messages failed and retry later, that seems to be to much for a user
   
   As @xiaofan-luan shows, cumulative ack actually provides a way for users to decide when their messages are acknowledged by default. For example, a user need to consume 10000 messages continuously. The user may discard all previous messages because the 8000th message is wrong. In this scenario, if cumulative ack is introduced, the user can call cumulative ack directly with the 8000th message and start to receive new message sequence. Caching message ids here I don't think is a good idea.
   
   If cumulative ack is considered to be introduced, I will implement it. @RobertIndie @nodece Could you give some comments? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org