You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/22 05:13:56 UTC
[GitHub] [flink] zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
zhengcanbin commented on a change in pull request #10973: [FLINK-15647][k8s] Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r395536051
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX = "kubernetes.jobmanager.annotation.";
Review comment:
1. Since the value can contain `:` and `,`, it seems we could not use the map type.
2. We could add descriptions too in the document, just like what we have done for the `containerized.master.env.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services