You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/05/30 14:05:50 UTC
[GitHub] [incubator-mxnet] piotrwolinski-intel opened a new pull request, #21046: [master] Node elimination graph pass
piotrwolinski-intel opened a new pull request, #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046
## Description ##
This PR is meant to make runtime graph consistent with model graph and to make fusing graph easier.
Elimination pass is actually used from [this](https://github.com/apache/incubator-mxnet/blob/master/src/imperative/eliminate_common_expr_pass.cc) file, so that the code is not unnecessarily duplicated.
This pass can be turned off via environment variable `MXNET_NODE_ELIMINATION` which is `True` by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1155194465
Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1164165248
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a diff in pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
anko-intel commented on code in PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#discussion_r902548998
##########
tests/python/dnnl/subgraphs/test_amp_subgraph.py:
##########
@@ -172,6 +173,7 @@ def test_amp_transformers():
@mx.util.use_np
def test_amp_concat():
+ os.environ["MXNET_NODE_ELIMINATION"] = "0"
Review Comment:
To avoid disabling the lemination pass you can modyfy the test to the following one:
```
@mx.util.use_np
def test_amp_concat():
class TestNet(nn.HybridBlock):
def __init__(self):
super(TestNet, self).__init__()
self.fc1 = nn.Dense(16)
self.fc2 = nn.Dense(16)
self.fc2.share_parameters(self.fc1.collect_params())
def forward(self, x):
xx = mx.nd.elemwise_add(x.as_nd_ndarray(), x.as_nd_ndarray()).as_np_ndarray()
x1 = self.fc1(xx)
x2 = self.fc2(x)
x = mx.np.concat((x1, x2), axis=1)
return x
net = TestNet()
net.initialize()
data_example = mx.np.random.uniform(-1, 1, (1, 16))
exp_data = mx.symbol.Variable('data')
exp_amp_data = mx.symbol.amp_cast(exp_data, dtype=AMP_DTYPE)
exp_amp_data1 = exp_amp_data + exp_amp_data
exp_weight = mx.symbol.Variable('weight')
exp_bias = mx.symbol.Variable('bias')
exp_fc1 = mx.symbol.FullyConnected(exp_amp_data1, exp_weight, exp_bias, num_hidden=1)
exp_fc = mx.symbol.FullyConnected(exp_amp_data, exp_weight, exp_bias, num_hidden=1)
exp_sym = mx.symbol.Concat(exp_fc1, exp_fc)
exp_sym = mx.symbol.amp_cast(exp_sym, dtype='float32')
exp_sym = exp_sym.get_backend_symbol(SG_PASS_NAME)
check_amp_fuse(net, [data_example], exp_sym)
amp_weight = mx.symbol.amp_cast(exp_weight, dtype=AMP_DTYPE)
amp_bias = mx.symbol.amp_cast(exp_bias, dtype=AMP_DTYPE)
exp_data1 = exp_data + exp_data
exp_amp_data1 = mx.symbol.amp_cast(exp_data1, dtype=AMP_DTYPE)
exp_fc1 = mx.symbol.FullyConnected(exp_amp_data1, amp_weight, amp_bias, num_hidden=1)
exp_fc = mx.symbol.FullyConnected(exp_data, exp_weight, exp_bias, num_hidden=1)
exp_sym = mx.symbol.Concat(exp_fc1, exp_fc)
exp_sym = exp_sym.get_backend_symbol(SG_PASS_NAME)
check_amp_fuse(net, [data_example], exp_sym, ['sg_onednn_fully_connected_1'])
```
and line 72:
`net.optimize_for(*data_example, backend=SG_PASS_NAME)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1161909683
@mxnet-bot run ci [clang]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1156069675
Jenkins CI successfully triggered : [windows-gpu, unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1155200434
Jenkins CI successfully triggered : [edge, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1155200304
@mxnet-bot run ci [edge, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1162783553
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1160282403
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1162783481
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a diff in pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
anko-intel commented on code in PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#discussion_r902548998
##########
tests/python/dnnl/subgraphs/test_amp_subgraph.py:
##########
@@ -172,6 +173,7 @@ def test_amp_transformers():
@mx.util.use_np
def test_amp_concat():
+ os.environ["MXNET_NODE_ELIMINATION"] = "0"
Review Comment:
To avoid disabling the elimination pass you can modyfy the test to the following one:
```
@mx.util.use_np
def test_amp_concat():
class TestNet(nn.HybridBlock):
def __init__(self):
super(TestNet, self).__init__()
self.fc1 = nn.Dense(16)
self.fc2 = nn.Dense(16)
self.fc2.share_parameters(self.fc1.collect_params())
def forward(self, x):
xx = mx.nd.elemwise_add(x.as_nd_ndarray(), x.as_nd_ndarray()).as_np_ndarray()
x1 = self.fc1(xx)
x2 = self.fc2(x)
x = mx.np.concat((x1, x2), axis=1)
return x
net = TestNet()
net.initialize()
data_example = mx.np.random.uniform(-1, 1, (1, 16))
exp_data = mx.symbol.Variable('data')
exp_amp_data = mx.symbol.amp_cast(exp_data, dtype=AMP_DTYPE)
exp_amp_data1 = exp_amp_data + exp_amp_data
exp_weight = mx.symbol.Variable('weight')
exp_bias = mx.symbol.Variable('bias')
exp_fc1 = mx.symbol.FullyConnected(exp_amp_data1, exp_weight, exp_bias, num_hidden=1)
exp_fc = mx.symbol.FullyConnected(exp_amp_data, exp_weight, exp_bias, num_hidden=1)
exp_sym = mx.symbol.Concat(exp_fc1, exp_fc)
exp_sym = mx.symbol.amp_cast(exp_sym, dtype='float32')
exp_sym = exp_sym.get_backend_symbol(SG_PASS_NAME)
check_amp_fuse(net, [data_example], exp_sym)
amp_weight = mx.symbol.amp_cast(exp_weight, dtype=AMP_DTYPE)
amp_bias = mx.symbol.amp_cast(exp_bias, dtype=AMP_DTYPE)
exp_data1 = exp_data + exp_data
exp_amp_data1 = mx.symbol.amp_cast(exp_data1, dtype=AMP_DTYPE)
exp_fc1 = mx.symbol.FullyConnected(exp_amp_data1, amp_weight, amp_bias, num_hidden=1)
exp_fc = mx.symbol.FullyConnected(exp_data, exp_weight, exp_bias, num_hidden=1)
exp_sym = mx.symbol.Concat(exp_fc1, exp_fc)
exp_sym = exp_sym.get_backend_symbol(SG_PASS_NAME)
check_amp_fuse(net, [data_example], exp_sym, ['sg_onednn_fully_connected_1'])
```
and line 72:
`net.optimize_for(*data_example, backend=SG_PASS_NAME)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1155194423
@mxnet-bot run ci [edge, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1141238960
> > Why in two places you added "EliminateCommonNodes" but in one "EliminateCommonNodesPass"?
> > Do you think it is necessary to have these two as separate entities? Maybe it would be better to use just "EliminateCommonNodes" and add the "ON/OFF" flag there?
>
> Actually it is a mistake on my side, `EliminateCommonNodes` was used during my earlier attempts to make it work and I forgot to change it, so thank You very much for pointing this out!
So now there are two separate passes "EliminateCommonNodes" and "EliminateCommonNodesPass"? Or the first one does not exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1160282460
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1161877086
Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1164164818
[@mxnet-bot](https://github.com/mxnet-bot) run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1161909819
Jenkins CI successfully triggered : [clang]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych merged PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1141954192
> > > Why in two places you added "EliminateCommonNodes" but in one "EliminateCommonNodesPass"?
> > > Do you think it is necessary to have these two as separate entities? Maybe it would be better to use just "EliminateCommonNodes" and add the "ON/OFF" flag there?
> >
> >
> > Actually it is a mistake on my side, `EliminateCommonNodes` was used during my earlier attempts to make it work and I forgot to change it, so thank You very much for pointing this out!
>
> So now there are two separate passes "EliminateCommonNodes" and "EliminateCommonNodesPass"? Or the first one does not exist?
Yes, the first does not exist and only `EliminateCommonNodesPass` is valid one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1141235855
> Why in two places you added "EliminateCommonNodes" but in one "EliminateCommonNodesPass"?
>
> Do you think it is necessary to have these two as separate entities? Maybe it would be better to use just "EliminateCommonNodes" and add the "ON/OFF" flag there?
Actually it is a mistake on my side, `EliminateCommonNodes` was used during my earlier attempts to make it work and I forgot to change it, so thank You very much for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1142037018
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, website, miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1156069547
@mxnet-bot run ci [unix-gpu, unix-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on code in PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#discussion_r902560581
##########
tests/python/dnnl/subgraphs/test_amp_subgraph.py:
##########
@@ -172,6 +173,7 @@ def test_amp_transformers():
@mx.util.use_np
def test_amp_concat():
+ os.environ["MXNET_NODE_ELIMINATION"] = "0"
Review Comment:
@bgawrych
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on a diff in pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on code in PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#discussion_r902572550
##########
tests/python/dnnl/subgraphs/test_amp_subgraph.py:
##########
@@ -172,6 +173,7 @@ def test_amp_transformers():
@mx.util.use_np
def test_amp_concat():
+ os.environ["MXNET_NODE_ELIMINATION"] = "0"
Review Comment:
personally I don't like this casting from nd to np - I would rather disable sharing parameters in FC and rewrite exected symbol:
```
@mx.util.use_np
def test_amp_concat():
class TestNet(nn.HybridBlock):
def __init__(self):
super(TestNet, self).__init__()
self.fc1 = nn.Dense(16)
self.fc2 = nn.Dense(16)
def forward(self, x):
x1 = self.fc1(x)
x2 = self.fc2(x)
x = mx.np.concat((x1, x2), axis=1)
return x
net = TestNet()
net.initialize()
data_example = mx.np.random.uniform(-1, 1, (1, 16))
exp_data = mx.symbol.Variable('data')
exp_amp_data = mx.symbol.amp_cast(exp_data, dtype=AMP_DTYPE)
exp_weight = [mx.symbol.Variable(f"fc{i}_weight") for i in range(2)]
exp_bias = [mx.symbol.Variable(f"fc{i}_bias") for i in range(2)]
exp_fc = [mx.symbol.FullyConnected(exp_amp_data, exp_weight[i], exp_bias[i], num_hidden=1)
for i in range(2)]
exp_sym = mx.symbol.Concat(*exp_fc)
exp_sym = mx.symbol.amp_cast(exp_sym, dtype='float32')
exp_sym = exp_sym.get_backend_symbol(SG_PASS_NAME)
check_amp_fuse(net, [data_example], exp_sym)
exp_fc[0] = mx.symbol.FullyConnected(exp_amp_data, exp_weight[0], exp_bias[0], num_hidden=1)
exp_fc[1] = mx.symbol.FullyConnected(exp_data, exp_weight[1], exp_bias[1], num_hidden=1)
exp_sym = mx.symbol.Concat(*exp_fc)
exp_sym = exp_sym.get_backend_symbol(SG_PASS_NAME)
check_amp_fuse(net, [data_example], exp_sym, ['sg_onednn_fully_connected_1'])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1141199438
Hey @piotrwolinski-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, centos-gpu, windows-cpu, unix-cpu, windows-gpu, clang, website, sanity, miscellaneous, unix-gpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1142037124
Jenkins CI successfully triggered : [centos-gpu, website, unix-gpu, miscellaneous, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1164164851
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bgawrych commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1164165166
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21046: [master] Node elimination graph pass
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21046:
URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1161876977
@mxnet-bot run ci [clang]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org