You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Igor Belakovskiy <bu...@alum.mit.edu> on 2011/10/02 18:49:28 UTC
Review Request: Review Request--patch to
org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location. Overriding
the default toString() method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2144/
-----------------------------------------------------------
Review request for shindig and Henry Saputra.
Summary
-------
Had to override the default toString() method in org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location to return the underlying value in Enum, instead of the Enum name, to mimic the class used in the spec package.
This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1630.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1630
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1174912
Diff: https://reviews.apache.org/r/2144/diff
Testing
-------
Manual testing.
Thanks,
Igor
Re: Review Request: Review Request--patch to
org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location. Overriding
the default toString() method.
Posted by Igor Belakovskiy <bu...@alum.mit.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2144/
-----------------------------------------------------------
(Updated 2011-10-03 15:53:29.823897)
Review request for shindig and Henry Saputra.
Changes
-------
Updated the bug link to relative instead of absolute
Summary
-------
Had to override the default toString() method in org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location to return the underlying value in Enum, instead of the Enum name, to mimic the class used in the spec package.
This addresses bug SHINDIG-1630.
https://issues.apache.org/jira/browse/SHINDIG-1630
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1174912
Diff: https://reviews.apache.org/r/2144/diff
Testing
-------
Manual testing.
Thanks,
Igor