You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/20 12:16:33 UTC
[GitHub] [nifi] pvillard31 opened a new pull request #4768: NIFI-8155 - add banner text in page title
pvillard31 opened a new pull request #4768:
URL: https://github.com/apache/nifi/pull/4768
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581
Thanks for looking into this @exceptionfactory. As far as I can tell the other places you mentioned are not "really" opening new windows and this not impacting the overall page title:
<img width="869" alt="Screenshot 2021-01-21 at 11 53 43" src="https://user-images.githubusercontent.com/11541012/105320361-801ab280-5bdf-11eb-8fc0-969aac536b0c.png">
The only edge case I can think of is when looking at the content of a flow file: this will open a new tab/window and the title won't contain the info. But I believe this a very special edge case and I think this is best to leave it outside of the change.
<img width="869" alt="Screenshot 2021-01-21 at 11 53 43" src="https://user-images.githubusercontent.com/11541012/105320626-d687f100-5bdf-11eb-9785-7dc48cb1da51.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #4768:
URL: https://github.com/apache/nifi/pull/4768
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 edited a comment on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
pvillard31 edited a comment on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581
Thanks for looking into this @exceptionfactory. As far as I can tell the other places you mentioned are not "really" opening new windows and this not impacting the overall page title:
<img width="869" alt="Screenshot 2021-01-21 at 11 53 43" src="https://user-images.githubusercontent.com/11541012/105320361-801ab280-5bdf-11eb-8fc0-969aac536b0c.png">
The only edge case I can think of is when looking at the content of a flow file: this will open a new tab/window and the title won't contain the info. But I believe this a very special edge case and I think this is best to leave it outside of the change.
<img width="640" alt="Screenshot 2021-01-21 at 11 57 22" src="https://user-images.githubusercontent.com/11541012/105320689-e8699400-5bdf-11eb-84a7-dff5269efa25.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-763755846
This change looks straightforward as it stands, but there are several other places where the `document.title` is set when opening new windows, such as Provenance contents or Bulletin Board messages. Should those other references also be updated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581
Thanks for looking into this @exceptionfactory. As far as I can tell the other places you mentioned are not "really" opening new windows and this not impacting the overall page title:
<img width="869" alt="Screenshot 2021-01-21 at 11 53 43" src="https://user-images.githubusercontent.com/11541012/105320361-801ab280-5bdf-11eb-8fc0-969aac536b0c.png">
The only edge case I can think of is when looking at the content of a flow file: this will open a new tab/window and the title won't contain the info. But I believe this a very special edge case and I think this is best to leave it outside of the change.
<img width="869" alt="Screenshot 2021-01-21 at 11 53 43" src="https://user-images.githubusercontent.com/11541012/105320626-d687f100-5bdf-11eb-9785-7dc48cb1da51.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-770117150
+1 LGTM, even tried script injection to the `nifi.ui.banner.text` property and it still worked as expected. I agree with pvillard31's answers to exceptionfactory's good question, so thanks for the improvement! Merging to main. If we need to handle more use cases please feel free to re-open the Jira and document the desired changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 edited a comment on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
pvillard31 edited a comment on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581
Thanks for looking into this @exceptionfactory. As far as I can tell the other places you mentioned are not "really" opening new windows and this not impacting the overall page title:
<img width="869" alt="Screenshot 2021-01-21 at 11 53 43" src="https://user-images.githubusercontent.com/11541012/105320361-801ab280-5bdf-11eb-8fc0-969aac536b0c.png">
The only edge case I can think of is when looking at the content of a flow file: this will open a new tab/window and the title won't contain the info. But I believe this a very special edge case and I think this is best to leave it outside of the change.
<img width="640" alt="Screenshot 2021-01-21 at 11 57 22" src="https://user-images.githubusercontent.com/11541012/105320689-e8699400-5bdf-11eb-84a7-dff5269efa25.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4768: NIFI-8155 - add banner text in page title
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-763565886
<img width="349" alt="Screenshot 2021-01-20 at 16 13 11" src="https://user-images.githubusercontent.com/11541012/105173772-eac5e280-5b3a-11eb-8967-377826c2b043.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org