You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/04/14 02:56:57 UTC

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4926: feat(framework): backend support cognito

klesh commented on code in PR #4926:
URL: https://github.com/apache/incubator-devlake/pull/4926#discussion_r1166228551


##########
backend/server/services/cognito.go:
##########
@@ -0,0 +1,187 @@
+/*

Review Comment:
   good call.
   I would prefer the package to be called `auth`, and it could offer multiple auth mechanisms in the future, including `cognito` and others like `OAuth` and `SAML`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org