[jira] [Work logged] (BEAM-14081) [CdapIO] Design and implement Context wrapper class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14081?focusedWorklogId=742662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742662 ]

ASF GitHub Bot logged work on BEAM-14081:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/22 18:44
            Start Date: 16/Mar/22 18:44
    Worklog Time Spent: 10m 
      Work Description: Krasavinigor opened a new pull request #17104:
URL: https://github.com/apache/beam/pull/17104


   Changes:
   * Implements classes for `BatchSourceContext`, `BatchSinkContext` and `StreamingSourceContext` interfaces.
   * Implements BatchContextImpl as part of _**has-a** references_ for classes.
   * Implements tests.
   
   We move all common logic to BatchContextImpl which implements the CDAP interface **BatchContext**. Each class extends **BatchContextImpl** and can override it if needed and contains its own logic.
   
   ![ContextWrappers drawio (3)](https://user-images.githubusercontent.com/48414875/150973575-4a168c3c-2790-478a-9a19-2853232c640a.png)
   
   After creating the plugin config and an instance of [PluginName]BatchSink/BatchSource/StreamingSource we pass our context through the `prepareRun` method for in instance.
   
   ![ContextWrapper Sequence Diagram drawio (3)](https://user-images.githubusercontent.com/48414875/150983953-1807ca7b-85d2-4ae7-9474-b305617f16b5.png)
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 742662)
    Remaining Estimate: 0h
            Time Spent: 10m

> [CdapIO] Design and implement Context wrapper class
> ---------------------------------------------------
>
>                 Key: BEAM-14081
>                 URL: https://issues.apache.org/jira/browse/BEAM-14081
>             Project: Beam
>          Issue Type: Task
>          Components: io-java-cdap
>            Reporter: Elizaveta Lomteva
>            Assignee: Igor Krasavin
>            Priority: P2
>              Labels: cdap-io-sprint-2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> h3. Context:
> CDAP plugins use context classes (ex. {{{}io.cdap.cdap.etl.api.batch.BatchSourceContext{}}}) to provide the updates and support additional logic (ex. [FailureCollector|https://github.com/data-integrations/salesforce/blob/d0d83fd82bbdbbb7ef07168f3b1698eebdc90c3e/src/main/java/io/cdap/plugin/salesforce/plugin/source/batch/SalesforceBatchSource.java#L96] or [getting timestamp|https://github.com/data-integrations/salesforce/blob/d0d83fd82bbdbbb7ef07168f3b1698eebdc90c3e/src/main/java/io/cdap/plugin/salesforce/plugin/source/batch/SalesforceBatchSource.java#L111]) in Source or Sink class methods (ex. {{{}SalesforceBatchSink{}}}).
> h3. Task Description:
> Required to design wrapper class(es) (it could be an heir of the original class) for the CDAP context classes so that the CDAP context instance can be created in the Apache Beam connector and used when calling the Source/Sink methods that require the context as an argument (ex. {{prepareRun(BatchSinkContext context)}} [method|https://github.com/data-integrations/salesforce/blob/d0d83fd82bbdbbb7ef07168f3b1698eebdc90c3e/src/main/java/io/cdap/plugin/salesforce/plugin/sink/batch/SalesforceBatchSink.java#L67]).
> h3. Acceptance criteria:
> Class diagram and source code of CDAP context logic wrapper class(es) that will provide an original context class logic



--
This message was sent by Atlassian Jira
(v8.20.1#820001)