[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

[GitBox <gi...@apache.org>]

LiteSun commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607460099



##########
File path: web/src/locales/en-US/component.ts
##########
@@ -25,12 +25,12 @@ export default {
   'component.global.document': 'Document',
   'component.global.enable': 'Enable',
   'component.global.scope': 'Scope',
-  'component.global.data.editor': 'Data Editor',
+  'component.global.data.editor': 'CodeMirror',
   'component.global.delete': 'Delete',
   'component.global.cancel': 'Cancel',
   'component.global.submit': 'Submit',
   'component.global.create': 'Create',
-  'component.global.createWithEditor': 'Create with Editor',

Review comment:
       I think `Create with Editor` is easier to understand, those who have not used `CodeMirror ` before may not know what codemirror does. 🤔




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org