You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/04 11:12:26 UTC

[GitHub] [camel-quarkus] ppalaga commented on pull request #1991: Added nagios native support #1726

ppalaga commented on pull request #1991:
URL: https://github.com/apache/camel-quarkus/pull/1991#issuecomment-721669878


   Overall, this looks good, thanks @aldettinger !
   
   I'd like to ask about some details:
   
   * Since recently, we try to make tests runnable in two modes: real backend service vs. mocked backend. There is also some log message based auditing convention so that interested parties can make sure that the tests were actually run against real services. IIRC, Twillio is one of the recent examples. The current proposal seems to support only the mock mode. I wonder whether the real mode could be supported too? cc @llowinge 
   * @jamesnetherton recently started to use WireMock for mocking backend services. I wonder whether it would also make sense to use it also here? I have no idea whether WireMock supports raw TCP. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org