[GitHub] [airflow] potiuk edited a comment on pull request #19189: Swtich both PROD and CI images to use virtual environments

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#issuecomment-991963742


   @uranusjr  @mik-laj   - I split the Dockerfile modiffcation from this one  and #19210 into #20238.
   
   I do not think I am going to pursue the venv route actually (at least not shortly). 
   
   The way how we could easily create venv from within an already active venv is at odds with how PythonVirtualenv works for Apache Airflow.
   
   I thought a bit on that and gave myself time to think about it and I think this case (Creating a venv dynamically from another venv) is where the venv approach cannot really work in the same way as if "system" installed application, so I am not going to make Airflow work this way. 
   
   I will think if I want to come back at all to my suggestions to PEP 668. I gave myself time to think, and to be honest I found myself quite demotivated. I thought I've followed the advice on trying to contribute there, I've followed up, gave the context, presented my experience and willingness to clarify things, but I do not see any interest of the people who are involved there. Seems like clarifying soime of  the "venv" statements and prefering to leave them in "vague" state without any user guidance,  rather than clarifying cases where it might not be the best approach (for cases like ours for exampel). Which I think is not best approach, but then, who am I to judge.
   
   So I think I will simply ignore that PEP for now (which is still in draft) - let's see if it gets an approval and adoption. For now I will just add a comment in our build process that "our case is different and the warning from PIP is not relevant". 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org