[GitHub] [beam] damccorm commented on a diff in pull request #25785: Upgrade tox from 3.x.x to 4.x.x

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on code in PR #25785:
URL: https://github.com/apache/beam/pull/25785#discussion_r1137652766


##########
sdks/python/tox.ini:
##########
@@ -64,8 +64,9 @@ commands = false {envname} is misconfigured
 
 [testenv:py{37,38,39,310}]
 commands =
+  pip install -r build-requirements.txt

Review Comment:
   2 questions:
   1) Can we use deps like https://github.com/apache/beam/blob/ebb49fd9a52d07684bcc088ce024cdd9dc6b8cda/sdks/python/tox.ini#L42
   2) If we're no longer automatically installing build-requirements.txt, do we need this on all of our testenv sections?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org