You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/15 21:34:48 UTC
Review Request 55548: Used `os::environment` instead of
`os::raw::environment` in agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55548/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Repository: mesos
Description
-------
This is necessary as a follow-up to r/5547, which removes
`os::raw::environment` from Stout's Windows API.
Diffs
-----
src/tests/environment.cpp a9e217e8beb5a6aca456ff5379893953cafca135
Diff: https://reviews.apache.org/r/55548/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55548: Used `os::environment` instead of
`os::raw::environment` in agent.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55548/#review162757
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/environment.cpp (line 30)
<https://reviews.apache.org/r/55548/#comment234101>
Won't need this if we use `foreach` instead below.
src/tests/environment.cpp (line 802)
<https://reviews.apache.org/r/55548/#comment234097>
For consistency, let's use the helper from `stout/foreach.hpp` instead.
- Joseph Wu
On Jan. 15, 2017, 6:25 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55548/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 6:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is necessary as a follow-up to r/5547, which removes
> `os::raw::environment` from Stout's Windows API.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp a9e217e8beb5a6aca456ff5379893953cafca135
>
> Diff: https://reviews.apache.org/r/55548/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55548: Used `os::environment` instead of
`os::raw::environment` in agent.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55548/
-----------------------------------------------------------
(Updated Jan. 16, 2017, 2:25 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Changes
-------
Fix build for AC Linux.
Repository: mesos
Description
-------
This is necessary as a follow-up to r/5547, which removes
`os::raw::environment` from Stout's Windows API.
Diffs (updated)
-----
src/tests/environment.cpp a9e217e8beb5a6aca456ff5379893953cafca135
Diff: https://reviews.apache.org/r/55548/diff/
Testing
-------
Thanks,
Alex Clemmer