You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/22 08:16:25 UTC
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #18: Configure python environment and install esptool
xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool
URL: https://github.com/apache/incubator-nuttx-testing/pull/18#discussion_r396066270
##########
File path: cibuild.sh
##########
@@ -118,6 +123,7 @@ function xtensa-esp32-gcc-toolchain {
rm xtensa-esp32-elf-gcc8_2_0-esp32-2019r1-rc2-linux-amd64.tar
fi
xtensa-esp32-elf-gcc --version
+ pip install esptool
Review comment:
can we check some file doesn't exist before install esptool like we check $prebuilt/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services