You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2015/06/19 14:29:45 UTC
git commit: updated refs/heads/master to bb613ba
Repository: cloudstack
Updated Branches:
refs/heads/master 1532203e3 -> bb613baa2
findbugs: repeated condition seems c&p error the tested states sugest that EXPUNGED should be the last one
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
This closes #491
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/bb613baa
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/bb613baa
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/bb613baa
Branch: refs/heads/master
Commit: bb613baa2b716dfe9aa7aed08b6cdd2027395456
Parents: 1532203
Author: Daan Hoogland <da...@onecht.net>
Authored: Fri Jun 19 14:02:13 2015 +0200
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Fri Jun 19 15:26:53 2015 +0300
----------------------------------------------------------------------
server/src/com/cloud/storage/VolumeApiServiceImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/bb613baa/server/src/com/cloud/storage/VolumeApiServiceImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/storage/VolumeApiServiceImpl.java b/server/src/com/cloud/storage/VolumeApiServiceImpl.java
index 964c7bc..577c8f6 100644
--- a/server/src/com/cloud/storage/VolumeApiServiceImpl.java
+++ b/server/src/com/cloud/storage/VolumeApiServiceImpl.java
@@ -1212,7 +1212,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
}
try {
- if (volume.getState() != Volume.State.Destroy && volume.getState() != Volume.State.Expunging && volume.getState() != Volume.State.Expunging) {
+ if (volume.getState() != Volume.State.Destroy && volume.getState() != Volume.State.Expunging && volume.getState() != Volume.State.Expunged) {
Long instanceId = volume.getInstanceId();
if (!volService.destroyVolume(volume.getId())) {
return false;