You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@locus.apache.org on 2000/11/29 20:39:21 UTC
cvs commit: apache-2.0/src/modules/standard mod_actions.c
wrowe 00/11/29 11:39:19
Modified: src/modules/standard mod_actions.c
Log:
Fix some const confusion with simpler code.
XXX note that 1.3.13 grew the xmethods in some recent patch:
typedef struct {
table *action_types; /* Added with Action... */
char *scripted[METHODS]; /* Added with Script... */
array_header *xmethods; /* Added with Script -- extension methods */
} action_dir_config;
XXx seems like whoever applied needs to port forward to 2.0 :-)
Revision Changes Path
1.15 +1 -2 apache-2.0/src/modules/standard/mod_actions.c
Index: mod_actions.c
===================================================================
RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_actions.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- mod_actions.c 2000/08/02 05:27:14 1.14
+++ mod_actions.c 2000/11/29 19:39:17 1.15
@@ -99,10 +99,9 @@
static void *create_action_dir_config(apr_pool_t *p, char *dummy)
{
action_dir_config *new =
- (action_dir_config *) apr_palloc(p, sizeof(action_dir_config));
+ (action_dir_config *) apr_pcalloc(p, sizeof(action_dir_config));
new->action_types = apr_make_table(p, 4);
- memset(new->scripted, 0, sizeof(new->scripted));
return new;
}
Re: cvs commit: apache-2.0/src/modules/standard mod_actions.c
Posted by Greg Stein <gs...@lyra.org>.
I didn't see how "const confusion" was related to the change. There wasn't a
const anywhere...
Cheers,
-g
On Wed, Nov 29, 2000 at 01:57:38PM -0800, William A. Rowe, Jr. wrote:
> From: "Greg Stein" <gs...@lyra.org>
> To: <ne...@apache.org>
>
>
> > Euh... the log message doesn't seem to apply here...
>
> How is that, has xmethods been depreciated in 2.0?
>
> > On Wed, Nov 29, 2000 at 07:39:21PM -0000, wrowe@locus.apache.org wrote:
> > > wrowe 00/11/29 11:39:19
> > >
> > > Modified: src/modules/standard mod_actions.c
> > > Log:
> > > Fix some const confusion with simpler code.
> > >
> > > XXX note that 1.3.13 grew the xmethods in some recent patch:
> > > typedef struct {
> > > table *action_types; /* Added with Action... */
> > > char *scripted[METHODS]; /* Added with Script... */
> > > array_header *xmethods; /* Added with Script -- extension methods */
> > > } action_dir_config;
> > > XXx seems like whoever applied needs to port forward to 2.0 :-)
>
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apache-2.0/src/modules/standard mod_actions.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
From: "Greg Stein" <gs...@lyra.org>
To: <ne...@apache.org>
> Euh... the log message doesn't seem to apply here...
How is that, has xmethods been depreciated in 2.0?
> On Wed, Nov 29, 2000 at 07:39:21PM -0000, wrowe@locus.apache.org wrote:
> > wrowe 00/11/29 11:39:19
> >
> > Modified: src/modules/standard mod_actions.c
> > Log:
> > Fix some const confusion with simpler code.
> >
> > XXX note that 1.3.13 grew the xmethods in some recent patch:
> > typedef struct {
> > table *action_types; /* Added with Action... */
> > char *scripted[METHODS]; /* Added with Script... */
> > array_header *xmethods; /* Added with Script -- extension methods */
> > } action_dir_config;
> > XXx seems like whoever applied needs to port forward to 2.0 :-)
Re: cvs commit: apache-2.0/src/modules/standard mod_actions.c
Posted by Greg Stein <gs...@lyra.org>.
Euh... the log message doesn't seem to apply here...
Cheers,
-g
On Wed, Nov 29, 2000 at 07:39:21PM -0000, wrowe@locus.apache.org wrote:
> wrowe 00/11/29 11:39:19
>
> Modified: src/modules/standard mod_actions.c
> Log:
> Fix some const confusion with simpler code.
>
> XXX note that 1.3.13 grew the xmethods in some recent patch:
> typedef struct {
> table *action_types; /* Added with Action... */
> char *scripted[METHODS]; /* Added with Script... */
> array_header *xmethods; /* Added with Script -- extension methods */
> } action_dir_config;
> XXx seems like whoever applied needs to port forward to 2.0 :-)
>
> Revision Changes Path
> 1.15 +1 -2 apache-2.0/src/modules/standard/mod_actions.c
>
> Index: mod_actions.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_actions.c,v
> retrieving revision 1.14
> retrieving revision 1.15
> diff -u -r1.14 -r1.15
> --- mod_actions.c 2000/08/02 05:27:14 1.14
> +++ mod_actions.c 2000/11/29 19:39:17 1.15
> @@ -99,10 +99,9 @@
> static void *create_action_dir_config(apr_pool_t *p, char *dummy)
> {
> action_dir_config *new =
> - (action_dir_config *) apr_palloc(p, sizeof(action_dir_config));
> + (action_dir_config *) apr_pcalloc(p, sizeof(action_dir_config));
>
> new->action_types = apr_make_table(p, 4);
> - memset(new->scripted, 0, sizeof(new->scripted));
>
> return new;
> }
>
>
>
--
Greg Stein, http://www.lyra.org/