You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/06/15 10:15:40 UTC
[GitHub] [superset] sebastianliebscher opened a new issue, #24406: Tests fail for optional prophet forecasting functionality
sebastianliebscher opened a new issue, #24406:
URL: https://github.com/apache/superset/issues/24406
Without the installed prophet python package, the integration tests for prophet forecasting functionality (introduced in https://github.com/apache/superset/pull/10324) will be skipped. After installing the optional dependency `[prophet]` their tests will run but fail.
Upgrading to latest prophet version does not fix the issue.
#### How to reproduce the bug
- `pip install "prophet>=1.0.1, <1.1" "pystan<3.0"`
- `scripts/tests/run.sh --module tests/integration_tests/charts/data/api_tests.py`
### Expected results
integration tests pass
### Actual results
```sh
======================================================================================================================= FAILURES =======================================================================================================================
_____________________________________________________________________________________________________ TestPostChartDataApi.test_chart_data_prophet _____________________________________________________________________________________________________
self = <tests.integration_tests.charts.data.api_tests.TestPostChartDataApi testMethod=test_chart_data_prophet>
def test_chart_data_prophet(self):
"""
Chart data API: Ensure prophet post transformation works
"""
pytest.importorskip("prophet")
time_grain = "P1Y"
self.query_context_payload["queries"][0]["is_timeseries"] = True
self.query_context_payload["queries"][0]["groupby"] = []
self.query_context_payload["queries"][0]["extras"] = {
"time_grain_sqla": time_grain
}
self.query_context_payload["queries"][0]["granularity"] = "ds"
self.query_context_payload["queries"][0]["post_processing"] = [
{
"operation": "prophet",
"options": {
"time_grain": time_grain,
"periods": 3,
"confidence_interval": 0.9,
},
}
]
rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
> self.assertEqual(rv.status_code, 200)
E AssertionError: 400 != 200
tests/integration_tests/charts/data/api_tests.py:470: AssertionError
```
```sh
=============================================================================================================== short test summary info ================================================================================================================
FAILED tests/integration_tests/charts/data/api_tests.py::TestPostChartDataApi::test_chart_data_prophet - AssertionError: 400 != 200
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
================================================================================================ 1 failed, 8 passed, 1 skipped, 6558 warnings in 13.50s ================================================================================================
```
### Environment
- superset version: latest master
- python version: 3.9
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #24406: Tests fail for optional prophet forecasting functionality
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #24406:
URL: https://github.com/apache/superset/issues/24406#issuecomment-1623584685
@john-bodley Can we close this issue given #24129?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley closed issue #24406: Tests fail for optional prophet forecasting functionality
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley closed issue #24406: Tests fail for optional prophet forecasting functionality
URL: https://github.com/apache/superset/issues/24406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org