[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6690: Combine operators: remove redundant variables and override logger in subclass

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6690:
URL: https://github.com/apache/incubator-pinot/pull/6690#discussion_r596257840



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/MinMaxValueBasedSelectionOrderByCombineOperator.java
##########
@@ -54,18 +53,14 @@
  */
 @SuppressWarnings({"rawtypes", "unchecked"})
 public class MinMaxValueBasedSelectionOrderByCombineOperator extends BaseCombineOperator {
+  private static final Logger LOGGER = LoggerFactory.getLogger(MinMaxValueBasedSelectionOrderByCombineOperator.class);

Review comment:
       You might want to change the logger in `BaseCombineOperator` to private?

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##########
@@ -75,13 +74,6 @@ public BaseCombineOperator(List<Operator> operators, QueryContext queryContext,
     _futures = new Future[_numThreads];
   }
 
-  public BaseCombineOperator(List<Operator> operators, QueryContext queryContext, ExecutorService executorService,

Review comment:
       I would recommend keeping a different constructor for group-by combine operators and avoid creating the blocking queue because it is not needed. In the future, we might want to change the group-by combine operators to two phases merge like other combine operators, then we can remove the additional constructor




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org