You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/10/07 20:36:03 UTC

[GitHub] [yunikorn-site] lixmgl commented on a diff in pull request #188: [YUNIKORN-1315] Document how to use MaxApplication enforcement feature

lixmgl commented on code in PR #188:
URL: https://github.com/apache/yunikorn-site/pull/188#discussion_r990482180


##########
docs/user_guide/queue_config.md:
##########
@@ -262,9 +272,10 @@ The star "*" is the wildcard character and matches all users or groups.
 Duplicate entries in the lists are ignored and do not cause a parsing error.
 Specifying a star beside other list elements is not allowed.
 
-_maxapplications_ is an unsigned integer value, larger than 1, which allows you to limit the number of running applications for the configured user or group.
+_maxapplications_ is an integer value, larger than 1, which allows you to limit the number of running applications for the configured user or group.

Review Comment:
   I see, the reason I updated here is @pbacsko commented https://github.com/apache/yunikorn-core/pull/429#discussion_r961046263
   If you think we should keep unsigned type, i will revert and update PR 429 as well. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org