You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/18 13:35:56 UTC

[GitHub] [thrift] cspwizard commented on a change in pull request #1953: THRIFT-5000 Thrift docker image publish on releases appveyor pipeline…

cspwizard commented on a change in pull request #1953:
URL: https://github.com/apache/thrift/pull/1953#discussion_r442230429



##########
File path: build/docker/publish/Dockerfile
##########
@@ -0,0 +1,14 @@
+FROM gcc:8 as build
+
+RUN apt update && apt upgrade -y && apt install flex bison cmake -y
+
+WORKDIR /usr/src/thrift
+
+COPY . /usr/src/thrift
+
+RUN mkdir cmake-build && cd cmake-build && cmake -DWITH_SHARED_LIB=off .. && make

Review comment:
       it's already done there output image is based on ubuntu image and contains only thrift binary
   `FROM ubuntu 
   COPY --from=build /usr/src/thrift/cmake-build/bin/thrift /bin/thrift
   WORKDIR /thrift
   ENTRYPOINT ["thrift"]`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org