You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/17 03:06:33 UTC
[kudu-CR] Reformat raft-config-change.md to clean it up
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3399
to review the following change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Reformat raft-config-change.md to clean it up
It just needed a little bit of markdown syntax love.
Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
---
M docs/design-docs/raft-config-change.md
1 file changed, 60 insertions(+), 87 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/3399/1
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md
File docs/design-docs/raft-config-change.md:
Line 55
> Did we drop this because it's not possible to make it public? Or because it
It's just copy/paste of a couple sections of the dissertation. I thought it was a little plagiaristic to make public and probably not worth it.
If you think it's useful I could copy it to a location I can make public (my personal GMail account) and make it public. Thoughts?
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 1:
Rendered HTML: https://github.com/mpercy/kudu/blob/consensus-docs-4/docs/design-docs/raft-config-change.md
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md
File docs/design-docs/raft-config-change.md:
Line 55
> I don't know if it's useful; I haven't actually looked at it.
Yep. OK sounds good.
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3399
to look at the new patch set (#3).
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Reformat raft-config-change.md to clean it up
It needed a bit of markdown love.
Also, s/quorum/configuration/ when it makes sense. Sometimes we use the
word "membership" when it seems clearer to do so.
Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
---
M docs/design-docs/raft-config-change.md
1 file changed, 144 insertions(+), 175 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/3399/3
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md
File docs/design-docs/raft-config-change.md:
Line 55
> It's just copy/paste of a couple sections of the dissertation. I thought it
I don't know if it's useful; I haven't actually looked at it.
If it's truly just a few sections pulled from the dissertation, the link to the entire dissertation is a perfectly reasonable substitute.
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Reformat raft-config-change.md to clean it up
It needed a bit of markdown love.
Also, s/quorum/configuration/ when it makes sense. Sometimes we use the
word "membership" when it seems clearer to do so.
Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Reviewed-on: http://gerrit.cloudera.org:8080/3399
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/design-docs/raft-config-change.md
1 file changed, 144 insertions(+), 175 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2).
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Reformat raft-config-change.md to clean it up
It just needed a little bit of markdown syntax love.
Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
---
M docs/design-docs/raft-config-change.md
1 file changed, 61 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/3399/2
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/1850/
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1849/
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 3: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/1854/
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3399/3/docs/design-docs/raft-config-change.md
File docs/design-docs/raft-config-change.md:
Line 55
Did we drop this because it's not possible to make it public? Or because it's now its own doc in the design-docs directory? If the latter, could you link to it?
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reformat raft-config-change.md to clean it up
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Reformat raft-config-change.md to clean it up
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/1851/
--
To view, visit http://gerrit.cloudera.org:8080/3399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd37b8b22ae02dba6d3fd2c389dd97eafe61ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No