You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2011/05/26 16:18:47 UTC
[jira] [Created] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
JobClient creates a RunningJob with null status and profile
-----------------------------------------------------------
Key: MAPREDUCE-2535
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: client
Affects Versions: 0.20.204.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
So, Even-though not null check is there in the following user code, it did not help.
466 runningJob = jobClient.getJob(mapRedJobID);
467 if(runningJob != null) {
JobClient.getJob() should return null if status is null.
In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039755#comment-13039755 ]
Hadoop QA commented on MAPREDUCE-2535:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480551/MR-2535-0.20.20X-V1.patch
against trunk revision 1127444.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/307//console
This message is automatically generated.
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-2535:
-------------------------------------------
Attachment: MR-2535-0.20.20X-V1.patch
Because this is not targeted for trunk, and Jenkins will try to run this against trunk here are the test-patch results
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 4 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
I don't know why it complains about the eclipse classpath or javadocs. Both of those are false positives. The eclipse classpath did not change, and it is still 6 javadoc warnings.
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans reopened MAPREDUCE-2535:
--------------------------------------------
The fix is good, but it broke the system tests. Reopening the bug to add in a patch to fix the tests.
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-2535:
-------------------------------------------
Status: Patch Available (was: Open)
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-2535:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1
I committed this. Thanks, Robert!
I also added the test I missed from MAPREDUCE-2470
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-2535:
-------------------------------------------
Attachment: MR-2535-failures-v1.patch
MR-2535-failures-v1.patch should apply to both 0.20.205 and security-trunk
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch, MR-2535-failures-v1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045112#comment-13045112 ]
Robert Joseph Evans commented on MAPREDUCE-2535:
------------------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 18 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
The Eclipse issue and the Javadocs issues are bogus. I didn't even change and of the source, just tests.
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch, MR-2535-failures-v1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-2535) JobClient creates a RunningJob
with null status and profile
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas resolved MAPREDUCE-2535.
--------------------------------------
Resolution: Fixed
Committed the follow-up. Thanks for the quick fix.
> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2535
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.204.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-2535-0.20.20X-V1.patch, MR-2535-failures-v1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466 runningJob = jobClient.getJob(mapRedJobID);
> 467 if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira