You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "mark4z (via GitHub)" <gi...@apache.org> on 2023/12/10 16:41:46 UTC
[PR] [issue#7629] typo about mQ -> mq and getmQ -> getmq [rocketmq]
mark4z opened a new pull request, #7630:
URL: https://github.com/apache/rocketmq/pull/7630
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7629
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#7629] typo about mQ -> mq and getmQ -> getmq [rocketmq]
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z closed pull request #7630: [ISSUE#7629] typo about mQ -> mq and getmQ -> getmq
URL: https://github.com/apache/rocketmq/pull/7630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#7629] typo about mQ -> mq and getmQ -> getmq [rocketmq]
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z commented on PR #7630:
URL: https://github.com/apache/rocketmq/pull/7630#issuecomment-1849217722
看起来CI不怎么稳定
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#7629] typo about mQ -> mq and getmQ -> getmq [rocketmq]
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z closed pull request #7630: [ISSUE#7629] typo about mQ -> mq and getmQ -> getmq
URL: https://github.com/apache/rocketmq/pull/7630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#7629] typo about mQ -> mq and getmQ -> getmq [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7630:
URL: https://github.com/apache/rocketmq/pull/7630#issuecomment-1849022497
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `139 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`c2c29c2`)](https://app.codecov.io/gh/apache/rocketmq/commit/c2c29c2435e0626cfe4f49830fbdc0d9421d82b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.20% compared to head [(`650a512`)](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.22%.
> Report is 1 commits behind head on develop.
> :exclamation: Current head 650a512 differs from pull request most recent head c2ad253. Consider uploading reports for the commit c2ad253 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | 34.61% | [33 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...a/org/apache/rocketmq/client/impl/MQAdminImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUFkbWluSW1wbC5qYXZh) | 10.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | 57.50% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...lient/impl/consumer/DefaultMQPullConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdWxsQ29uc3VtZXJJbXBsLmphdmE=) | 31.81% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | 46.15% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | 46.15% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | 72.22% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/rocketmq/store/timer/TimerMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/rocketmq/broker/slave/SlaveSynchronize.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2xhdmUvU2xhdmVTeW5jaHJvbml6ZS5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...client/consumer/store/RemoteBrokerOffsetStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | 76.92% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [6 more](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7630 +/- ##
=============================================
+ Coverage 43.20% 43.22% +0.01%
- Complexity 9796 9801 +5
=============================================
Files 1164 1164
Lines 84420 84428 +8
Branches 10961 10963 +2
=============================================
+ Hits 36474 36490 +16
+ Misses 43420 43411 -9
- Partials 4526 4527 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7630?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org