You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by NormW <no...@gknw.net> on 2015/08/19 11:57:31 UTC

C89-ify a recent change to h2_io_set.c

G/Evening (Is here)
A very small tweak is proposed for:
  httpd-trunk\modules\http2\h2_io_set.c
to keep the C89-ers in their seats.

The svn diff looks like:
Index: modules/http2/h2_io_set.c
===================================================================
--- modules/http2/h2_io_set.c   (revision 1696548)
+++ modules/http2/h2_io_set.c   (working copy)
@@ -67,12 +67,13 @@
      /* we keep the array sorted by id, so lookup can be done
       * by bsearch.
       */
+    h2_io **ps;
      h2_io key;
      h2_io *pkey = &key;

      memset(&key, 0, sizeof(key));
      key.id = stream_id;
-    h2_io **ps = bsearch(&pkey, sp->list->elts, sp->list->nelts,
+    ps = bsearch(&pkey, sp->list->elts, sp->list->nelts,
                           sp->list->elt_size, h2_stream_id_cmp);
      return ps? *ps : NULL;
  }

I won't bore anyone who can follow that module with a patch.
Cheers,
Norm

Re: C89-ify a recent change to h2_io_set.c

Posted by Stefan Eissing <st...@greenbytes.de>.
> Am 19.08.2015 um 15:33 schrieb Jim Jagielski <ji...@jaguNET.com>:
> 
> That's the intent for --enable-maintainer-mode

Excellent. Thx!

<green/>bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: C89-ify a recent change to h2_io_set.c

Posted by Jim Jagielski <ji...@jaguNET.com>.
That's the intent for --enable-maintainer-mode

> On Aug 19, 2015, at 8:22 AM, Stefan Eissing <st...@greenbytes.de> wrote:
> 
> Thanks Jean-Frederic.
> 
> Is there a way to ./configure - other than CFLAGS - so that all developers can compile with similar subsets of features and warnings? I would like to write code so that it does not generate warnings for the rest of you...
> 
> //Stefan
> 
>> Am 19.08.2015 um 14:00 schrieb jean-frederic clere <jf...@gmail.com>:
>> 
>> On 08/19/2015 11:57 AM, NormW wrote:
>>> G/Evening (Is here)
>>> A very small tweak is proposed for:
>>> httpd-trunk\modules\http2\h2_io_set.c
>>> to keep the C89-ers in their seats.
>> 
>> thanks committed.
>> 
>> Cheers
>> 
>> Jean-Frederic
> 
> <green/>bytes GmbH
> Hafenweg 16, 48155 Münster, Germany
> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
> 
> 
>

Re: C89-ify a recent change to h2_io_set.c

Posted by Stefan Eissing <st...@greenbytes.de>.
Thanks Jean-Frederic.

Is there a way to ./configure - other than CFLAGS - so that all developers can compile with similar subsets of features and warnings? I would like to write code so that it does not generate warnings for the rest of you...

//Stefan

> Am 19.08.2015 um 14:00 schrieb jean-frederic clere <jf...@gmail.com>:
> 
> On 08/19/2015 11:57 AM, NormW wrote:
>> G/Evening (Is here)
>> A very small tweak is proposed for:
>>  httpd-trunk\modules\http2\h2_io_set.c
>> to keep the C89-ers in their seats.
> 
> thanks committed.
> 
> Cheers
> 
> Jean-Frederic

<green/>bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: C89-ify a recent change to h2_io_set.c

Posted by jean-frederic clere <jf...@gmail.com>.
On 08/19/2015 11:57 AM, NormW wrote:
> G/Evening (Is here)
> A very small tweak is proposed for:
>   httpd-trunk\modules\http2\h2_io_set.c
> to keep the C89-ers in their seats.

thanks committed.

Cheers

Jean-Frederic